multi: update walletdb #1001
Merged
multi: update walletdb #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziggie1984
force-pushed
the
update-walletdb-btcwallet
branch
2 times, most recently
from
3e97a04 to
1fc6ef9
Compare
bhandras
approved these changes
Apr 9, 2025
ziggie1984
force-pushed
the
update-walletdb-btcwallet
branch
from
1fc6ef9 to
9f02da9
Compare
yyforyongyu
approved these changes
Apr 9, 2025
| @@ -163,7 +163,7 @@ func rpcClientConnectLoop(legacyRPCServer *legacyrpc.Server, loader *wallet.Load | |||
| netDir := networkDir(cfg.AppDataDir.Value, activeNet.Params) | |||
| spvdb, err = walletdb.Create( | |||
| "bdb", filepath.Join(netDir, "neutrino.db"), | |||
| true, cfg.DBTimeout, | |||
| true, cfg.DBTimeout, false, | |||
There was a problem hiding this comment.
Some future PRs - we may create a walletdb config struct so it's easier to understand what these params mean
There was a problem hiding this comment.
def, not sure if it is possible tho, because the parameters are different for the other dbs ?
ziggie1984
force-pushed
the
update-walletdb-btcwallet
branch
from
9f02da9 to
e73d387
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
#998 (needs updated walletdb version)
and
#1000 (needs a new wtxmgr tag)