Skip to content

Conversation

gap-editor
Copy link

@gap-editor gap-editor commented May 3, 2025


Description

closes #939
This PR updates the logic for determining the watchOnly state by replacing a check on acctInfo.acctKeyPriv != nil with len(acctInfo.acctKeyPriv) == 0.
This ensures correct detection of accounts without usable private keys — even if the key slice is non-nil but empty — preventing unintended signing attempts.

Relevant Go documentation:

Pull Request Checklist

Testing

  • Your PR passes all CI checks.
  • Tests covering the positive and negative (error paths) are included.
  • Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

@guggero
Copy link
Collaborator

guggero commented May 5, 2025

Can you please at least try to compile your code changes before submitting a PR? Using the GitHub UI for creating PR will almost never result in a PR that satisfies the pull request checklist. Perhaps you should focus on quality of PRs instead of quantity. 26 PRs in such a short time makes you look like a bot farming commits (didn't you even have "collecting commits" in your GitHub profile description a few days ago?).
So if you're serious about "contributing to open-source projects ", please don't generate more review work than what your "contributions" are actually worth.

@guggero guggero closed this May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the error of getting acctKey
2 participants