wallet+wtxmgr: check credit in FetchOutpointInfo
#1011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyforyongyu
force-pushed
the
fix-fetchop
branch
2 times, most recently
from
dee5d91 to
d092695
Compare
ziggie1984
suggested changes
May 23, 2025
|
|
||
| // Create a tx that has two outputs - output1 belongs to the wallet, | ||
| // output2 is external. | ||
| output1 := wire.NewTxOut(100000, p2shAddr) |
There was a problem hiding this comment.
Hmm why do they they pay to the same addr thought therefore we created addr above ?
There was a problem hiding this comment.
doesn't matter but still better to have a proper logic in.
There was a problem hiding this comment.
they are dummy values - techinically they should be the same so we know the result doesn't depend on the pkscript, but again I don't think it matters.
wallet/utxos_test.go
Outdated
| name: "no credit found", | ||
| prevOut: &wire.OutPoint{ | ||
| Hash: tx.TxHash(), | ||
| Index: 1000, |
There was a problem hiding this comment.
wrong index probably you wanted to use 1 here ?
wallet/utxos_test.go
Outdated
| Hash: tx.TxHash(), | ||
| Index: 1000, | ||
| }, | ||
| errExpected: "invalid output index", |
There was a problem hiding this comment.
wrong error (when using with the right index (index 1) ?
There was a problem hiding this comment.
missing the success case as well ?
There was a problem hiding this comment.
see TestFetchOutpointInfo
To decide whether an outpoint belongs to the wallet or not, we need to further check that the specified output index is indeed a credit paid to us.
guggero
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To decide whether an outpoint belongs to the wallet or not, we need to further check that the specified output index is indeed a credit paid to us.