Skip to content

Conversation

mohamedawnallah
Copy link
Contributor

@mohamedawnallah mohamedawnallah commented Aug 19, 2025

Motivation and Context

Motivated by @guggero's comment #1043 (comment)

Steps to Test

Steps for reviewers to follow to test the change.

Pull Request Checklist

Testing

  • Your PR passes all CI checks.
  • Tests covering the positive and negative (error paths) are included.
  • Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

📝 Please see our Contribution Guidelines for further guidance.

@mohamedawnallah mohamedawnallah force-pushed the bump-Go-1.24 branch 2 times, most recently from 638bc73 to f71bd13 Compare August 19, 2025 15:51
@mohamedawnallah
Copy link
Contributor Author

mohamedawnallah commented Aug 19, 2025

Error: wallet/wallet.go:4094:3: right hand must be only type assertion (forcetypeassert)
privKey, err = addr.(waddrmgr.ManagedPubKeyAddress).PrivKey()

This linting failure mostly appears as false positive. I've tried make lint and all passes in addition that line of code not even exist in the codebase!

EDIT:
nvm just need to rebase on the upstream master branch

@mohamedawnallah mohamedawnallah force-pushed the bump-Go-1.24 branch 2 times, most recently from 4b9d62a to 7a81aae Compare August 19, 2025 16:06
@mohamedawnallah
Copy link
Contributor Author

cc: @yyforyongyu

@mohamedawnallah
Copy link
Contributor Author

Rebased on master branch. It is now ready for review

go 1.22
// If you change this please run `make lint` to see where else it needs to be
// pdated as well.
go 1.24.6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this will break its usage in lnd?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think LND should also be updated, since it is primarily a daemon.

@GustavoStingelin
Copy link
Contributor

tACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants