Add option to allow for dust when checking outputs #907
Conversation
|
You mentioned you need this for |
|
If the op return output is over the standard 80 byte limit it is considered dust. |
|
Ah yes. So you'd need a non-standard implementation of a chain backend to propagate such an output in the first place... |
|
Yeah I use Libre relay |
wallet/txrules/rules.go
Outdated
| @@ -39,14 +39,14 @@ var ( | |||
|
|
|||
| // CheckOutput performs simple consensus and policy tests on a transaction | |||
| // output. | |||
| func CheckOutput(output *wire.TxOut, relayFeePerKb btcutil.Amount) error { | |||
| func CheckOutput(output *wire.TxOut, relayFeePerKb btcutil.Amount, allowDust bool) error { | |||
There was a problem hiding this comment.
Since this is a breaking API change, should we just create a new function CheckOutputAllowDust that has the boolean flag? Then this function can call into the new one with false.
There was a problem hiding this comment.
Damn never saw this comment, updated!
|
this might actually be a better fix: btcsuite/btcd#2380 |
| return nil | ||
| } | ||
|
|
||
| // CheckOutput performs simple consensus and policy tests on a transaction |
There was a problem hiding this comment.
The comment here should be updated to match the function.
I think if the main goal is to fix btcwallet considering op_returns as dust, I think changing the behavior in btcwallet is the way to go because of the aforementioned comment here. |
This seems standard in most wallet libraries nowadays to give users the option to allow for dust if they know what they are doing.