-
Notifications
You must be signed in to change notification settings - Fork 36
Refactor and generalize particle modeling #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jbreue16
wants to merge
35
commits into
master
Choose a base branch
from
jb/dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceb97b1
to
5f5e6fd
Compare
bb857cd
to
a55d1b3
Compare
This was referenced Jun 8, 2025
This commit adds binding and reactions to particle operator, outsourcing that functionality from the GRM_DG
Implement new particle interface, maintain the old one for GRM, LRMP units Fix interface of homogeneous particles Add tests: GRM, LRMP, and mixed general rate and homogeneous particle type tests Allow nParType=0, i.e. DPF(R)
Always recompute Jacobian in 1D unit if wantJac Fix linear solve of inlet Jacobian block in 1D column unit Add compression to AD Jacobian Implement function to check analytic Jacobian against AD during simulation Add exception for NPARTYPE = 0 but particle group exists
… class to derived class
This commit removes the GRM_DG and LRMP_DG unit operation implementations, which became part of the generalized COLUMN_MODEL_1D
…cleDiffusionOperator
Remove obsolete newStaticJac in 1Dunit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This collection of PRs modularizes the particle model implementation and incorporates them into generalized unit operations.
TODO
unit_type
specification (which will still require the new particle interface exceptparticle_type
)Follow up issues