sp improv #2437
Merged
sp improv #2437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarHatem28
requested changes
Aug 19, 2025
lib/bitcoin/cw_bitcoin.dart
Outdated
Comment on lines
815
to
819
| bitcoinTx.unspents!.forEach((unspent) { | ||
| addresses.add(bitcoinWallet.walletAddresses.silentAddresses | ||
| .firstWhere((address) => address.silentPaymentTweak == unspent.silentPaymentLabel) | ||
| .address); | ||
| }); |
There was a problem hiding this comment.
wrap this with a try and catch, as this will be probably called with also normal transactions, so I believe firstWhere would throw an exception at that time
also rename the function to getSPTransactionAddresses since it only relates to SP
OmarHatem28
reviewed
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.