Skip to content

Conversation

punitdarira
Copy link
Contributor

@punitdarira punitdarira commented Apr 28, 2024

Telemetry API now has metrics and date filter.
Made changes in telemetry and metrics api to reuse code.

related to #4229

- telemetry/data now uses the same api of metrics/sum to get metrics with date range

related to camunda#4229
@CLAassistant
Copy link

CLAassistant commented Apr 28, 2024

CLA assistant check
All committers have signed the CLA.

@danielkelemen
Copy link
Member

Hi @punitdarira, thank you for your PR!

I'd need a bit more time to review this thoroughly. It already looks pretty good at first sight.
I can already tell you, that we would need a few more tests in the TelemetryRestServiceTest for instance, to test the newly added parameters and the results. But I'll provide more feedback soon.

-Daniel

@punitdarira
Copy link
Contributor Author

Hi @punitdarira, thank you for your PR!

I'd need a bit more time to review this thoroughly. It already looks pretty good at first sight. I can already tell you, that we would need a few more tests in the TelemetryRestServiceTest for instance, to test the newly added parameters and the results. But I'll provide more feedback soon.

-Daniel

Hi @danielkelemen,
I agree regarding the tests. I'll update this PR with the tests.

@tasso94
Copy link
Member

tasso94 commented Jul 29, 2025

Hi @punitdarira,

This PR got lost in the hustle and bustle. Sorry for replying only now.

Are you still interested in merging this? If yes, could you please resolve the merge conflicts before we review it?

Best,
Tassilo

@punitdarira
Copy link
Contributor Author

@tasso94
Sure I'll resolve the merge conflicts

@punitdarira
Copy link
Contributor Author

Hi @tasso94,
Since sending telemetry data is deprecated (#4486)
Can you please confirm whether this ticket is still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants