-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore(renovate): enable auto merge #5322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
related to #5214
@@ -3,7 +3,8 @@ | |||
"extends": [ | |||
"config:base" | |||
], | |||
"branchName": "{{{baseBranch}}}-{{{branchTopic}}}", | |||
"rebaseWhen": "behind-base-branch", | |||
"branchName": "{{{baseBranch}}}-renovate-{{{branchTopic}}}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Adding
-renovate
suffix so that the branch protection rule needed for auto-merge can distinguish between feature branches and renovate branches. {{{baseBranch}}}
must always come first since otherwise our CI wouldn't run.
@@ -3,7 +3,8 @@ | |||
"extends": [ | |||
"config:base" | |||
], | |||
"branchName": "{{{baseBranch}}}-{{{branchTopic}}}", | |||
"rebaseWhen": "behind-base-branch", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PRs should be rebased when behind base branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mistakenly already committed this to master without review :(
Maybe we can catch up on this now.
name: All checks passed | ||
runs-on: ubuntu-latest | ||
permissions: | ||
checks: read | ||
contents: read | ||
environment: delayenv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run will be delayed for 180 minutes. I don't know if this is enough to run our whole CI. However, we can tweak this.
related to #5214