Skip to content

Conversation

tasso94
Copy link
Member

@tasso94 tasso94 commented Jul 31, 2025

related to #5214

@@ -3,7 +3,8 @@
"extends": [
"config:base"
],
"branchName": "{{{baseBranch}}}-{{{branchTopic}}}",
"rebaseWhen": "behind-base-branch",
"branchName": "{{{baseBranch}}}-renovate-{{{branchTopic}}}",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Adding -renovate suffix so that the branch protection rule needed for auto-merge can distinguish between feature branches and renovate branches.
  • {{{baseBranch}}} must always come first since otherwise our CI wouldn't run.

@@ -3,7 +3,8 @@
"extends": [
"config:base"
],
"branchName": "{{{baseBranch}}}-{{{branchTopic}}}",
"rebaseWhen": "behind-base-branch",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs should be rebased when behind base branch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mistakenly already committed this to master without review :(
Maybe we can catch up on this now.

name: All checks passed
runs-on: ubuntu-latest
permissions:
checks: read
contents: read
environment: delayenv
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run will be delayed for 180 minutes. I don't know if this is enough to run our whole CI. However, we can tweak this.

@tasso94 tasso94 requested a review from HeleneW-dot July 31, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants