-
Notifications
You must be signed in to change notification settings - Fork 14
fix: Desktop icons and GTK config files #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Kyuyrii your changes as is are here. This works successfully in my testing. However, when links from an existing install exist it will still leave stale links in the applications directories (the I can iterate on this further to fix that issue if you'd like, if not, update your original PR and I can pull in any changes into this one when ready. |
I made a modification to remove the links from the Applications and Icons folder before copying the files into it. |
There's no point in keeping them because the code won't be able to differentiate between .desktop files generated by the Snap version and the deb version. And there's no need to change the command for the Snap version of Steam to be opened by these .desktop files, since when the deb version isn't installed, the Snap version is opened with the |
This was used to prevent the deb from being launched for snap installed games, but there isn't a good way to do this anymore when we link host dirs to the snap
Yeah I'd like to keep it if possible, but I don't see a good way for it to work with this linking method. Maybe something to revisit in the future, but we don't need to do it for this PR. |
See #449 (comment)
UDENG-7679