Skip to content

Conversation

ashuntu
Copy link
Contributor

@ashuntu ashuntu commented Aug 15, 2025

See #449 (comment)


UDENG-7679

@ashuntu ashuntu self-assigned this Aug 15, 2025
@ashuntu
Copy link
Contributor Author

ashuntu commented Aug 15, 2025

@Kyuyrii your changes as is are here.

This works successfully in my testing. However, when links from an existing install exist it will still leave stale links in the applications directories (the cp fails since the files refer to same thing).

I can iterate on this further to fix that issue if you'd like, if not, update your original PR and I can pull in any changes into this one when ready.

@Kyuyrii
Copy link

Kyuyrii commented Aug 15, 2025

This works successfully in my testing. However, when links from an existing install exist it will still leave stale links in the applications directories (the cp fails since the files refer to same thing).

I made a modification to remove the links from the Applications and Icons folder before copying the files into it.

b367faa

@Kyuyrii
Copy link

Kyuyrii commented Aug 15, 2025

I made other modifications to remove parts that are no longer necessary:

f5c5ed5

64de5b0

@ashuntu ashuntu marked this pull request as ready for review August 18, 2025 18:56
@ashuntu
Copy link
Contributor Author

ashuntu commented Aug 18, 2025

@Kyuyrii I can't request you to review for some reason, so just leave a comment or reaction with your approval.

I think we should keep what you removed in f5c5ed5 for now.

@Kyuyrii
Copy link

Kyuyrii commented Aug 19, 2025

I think we should keep what you removed in f5c5ed5 for now.

There's no point in keeping them because the code won't be able to differentiate between .desktop files generated by the Snap version and the deb version.

And there's no need to change the command for the Snap version of Steam to be opened by these .desktop files, since when the deb version isn't installed, the Snap version is opened with the steam command.

This was used to prevent the deb from being launched for snap installed games, but there isn't a good way to do this anymore when we link host dirs to the snap
@ashuntu
Copy link
Contributor Author

ashuntu commented Aug 19, 2025

Yeah I'd like to keep it if possible, but I don't see a good way for it to work with this linking method. Maybe something to revisit in the future, but we don't need to do it for this PR.

@ashuntu ashuntu merged commit 73d8053 into main Aug 25, 2025
2 checks passed
@ashuntu ashuntu deleted the fix-icons branch August 25, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants