Feat/users registration #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements user registration functionality by adding support for different types of user registration emails and enhancing the email service system. The changes include adding a new isMentor field to the User proto, creating multiple email services for different registration scenarios, and updating the cache system to support temporary passwords.
Key changes:
- Added three new email services for pre-registration, mentor/user registration, and expert registration
- Enhanced the email processing system with new cache support and improved data structures
- Updated the User proto to include mentor identification
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/proto/UsersService.proto | Added isMentor boolean field to User message |
| src/main/kotlin/org/careerseekers/csmailservice/services/PreRegistrationEmailService.kt | New service for handling pre-registration verification emails |
| src/main/kotlin/org/careerseekers/csmailservice/services/PasswordResetEmailService.kt | Refactored to support multiple user input methods and improved error handling |
| src/main/kotlin/org/careerseekers/csmailservice/services/MentorAndUserRegistrationEmailService.kt | New service for mentor registration confirmation emails |
| src/main/kotlin/org/careerseekers/csmailservice/services/ExpertRegistrationEmailService.kt | New service for expert registration with temporary password delivery |
| src/main/kotlin/org/careerseekers/csmailservice/services/EmailProcessingService.kt | Added mailer interface requirement for all email services |
| src/main/kotlin/org/careerseekers/csmailservice/io/converters/extensions/RpcUserToCacheUser.kt | Added isMentor field mapping |
| src/main/kotlin/org/careerseekers/csmailservice/enums/MailEventTypes.kt | Updated enum with new registration event types |
| src/main/kotlin/org/careerseekers/csmailservice/dto/KafkaMessagesDto.kt | Enhanced EmailSendingTaskDto with optional fields |
| src/main/kotlin/org/careerseekers/csmailservice/dto/CachesDto.kt | Added isMentor field and TemporaryPasswordDto |
| src/main/kotlin/org/careerseekers/csmailservice/config/RedisTemplatesConfig.kt | Added Redis template for temporary passwords |
| src/main/kotlin/org/careerseekers/csmailservice/cache/VerificationCodesCache.kt | Updated to use email instead of userId as cache key |
| src/main/kotlin/org/careerseekers/csmailservice/cache/TemporaryPasswordsCache.kt | New cache service for temporary passwords |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...ain/kotlin/org/careerseekers/csmailservice/services/MentorAndUserRegistrationEmailService.kt
Show resolved
Hide resolved
src/main/kotlin/org/careerseekers/csmailservice/services/ExpertRegistrationEmailService.kt
Show resolved
Hide resolved
...ain/kotlin/org/careerseekers/csmailservice/services/MentorAndUserRegistrationEmailService.kt
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied ☁️ View the detailed Qodana report Detected 116 dependenciesThird-party software listThis page lists the third-party software dependencies used in cs-mail-service
Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21