Patch resource history annotations instead of update #826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcmadhankumar
force-pushed
the
issue-472
branch
from
30d3a7c to
f3b3af9
Compare
Signed-off-by: rcmadhankumar <rcmadhankumar@gmail.com>
rcmadhankumar
force-pushed
the
issue-472
branch
from
f3b3af9 to
670bae2
Compare
|
Are we still planning on putting this change in? |
We do want to, the only reason we didn't do it yet is because some tests were failing in an older version of k8s and we couldn’t figure out the reason even after doing some investigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Patch resource history annotations instead of update which can avoid updating the entire resource while adding the resource history annotation.
Which issue(s) this PR fixes:
Fixes #472
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: