Skip to content

Remove third party reference to removed .extlib directory. #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

paulholden
Copy link
Contributor

No description provided.

@phager-at
Copy link

Shouldn't the thirdparty.xml include the dependencies now located in vendor/… instead?
So technically speaking everything in composer.lock? As it's included in the plugin/commit instead of being only a composer dependency?

Relevant changes:

  • Removal of .extlib: 2bb8542
  • Adding everything as composer dependency and also addingthe vendor-directory to the commit: 2c1f735

@paulholden
Copy link
Contributor Author

Shouldn't the thirdparty.xml include the dependencies now located in vendor/… instead? So technically speaking everything in composer.lock? As it's included in the plugin/commit instead of being only a composer dependency?

Relevant changes:

* Removal of .extlib: [2bb8542](https://github.com/catalyst/moodle-auth_saml2/commit/2bb85429ac288c3193ac523126db1dacbb798080)

* Adding everything as composer dependency and also addingthe vendor-directory to the commit: [2c1f735](https://github.com/catalyst/moodle-auth_saml2/commit/2c1f735fba9ee83e82aa94d2d4e462eb1dcb2335)

As I commented on the issue, there are indeed more places that should be changed, but I don't work for Catalyst so can't say who or where said changes should happen. I'd suggest opening another issue

@danmarsden danmarsden merged commit 4c4bf2c into catalyst:MOODLE_405_STABLE Mar 31, 2025
3 of 7 checks passed
@danmarsden
Copy link
Member

Merging this in for now - hopefully @jay-oswald will clean up the other things? (adding vendor to thirdpartylibs.xml and fixing the other references to .extlib.)

@paulholden paulholden deleted the third-party-extlib branch March 31, 2025 19:48
@jay-oswald
Copy link
Contributor

Just made #888 to clean up the rest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants