Skip to content

T19 saml2 update simplesaml 2.0.15 #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2025
Merged

Conversation

bwalkerl
Copy link
Contributor

@bwalkerl bwalkerl commented Aug 15, 2025

Cherry-pick of #911 with no conflicts.

Kept the original bump version from T13 to avoid duplication upon upgrades, but at the time of writing the T13 branch hasn't updated the version in the version.php file. The version here has been updated to the current date as it's the most recent TOTARA branch - no idea if we want to keep this partly in line with Moodle branches.

This cherry-pick is still somewhat messy and we should update composer done like the Moodle 4.5 branch. But the T19 branch is still quite similar to MOODLE_39_STABLE and TOTARA_13_STABLE so it's better to have the updated than not?

There's minimal changes on this branch compared to T13 and it's working locally in my testing.

The unit test failures are because CI/tests are run on Moodle - they pass locally.

@bwalkerl bwalkerl requested a review from jay-oswald August 18, 2025 04:19
@jay-oswald
Copy link
Contributor

Cherry pick my git-destroying commit isn't ideal, but like you said better to have it done than not done at all. We can switch to the new composer version properly in a future upgrade. We still have full commit history on the 401 branch, and hopefully a future upgrade can copy the patch files from 405 anyway.

So yeah not ideal, but I think better than leaving it as-is, and shouldn't introduce any major issues in the future.

@bwalkerl bwalkerl merged commit 54a1851 into TOTARA_19 Aug 18, 2025
7 of 18 checks passed
@bwalkerl bwalkerl deleted the t19-update-simplesaml branch August 18, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants