Fix up ci.yml #109
Open
Fix up ci.yml #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duyhuynhdev
force-pushed
the
fix-up-ci-yml-WR-468063
branch
3 times, most recently
from
02cb4e6 to
da6fe61
Compare
duyhuynhdev
force-pushed
the
fix-up-ci-yml-WR-468063
branch
9 times, most recently
from
eff708b to
89c3d95
Compare
duyhuynhdev
force-pushed
the
fix-up-ci-yml-WR-468063
branch
from
89c3d95 to
42343f8
Compare
dmitriim
reviewed
Aug 23, 2025
| $plugin->requires = 2017051500; // Requires Moodle 3.3 version. | ||
| $plugin->component = 'auth_userkey'; // Full name of the plugin (used for diagnostics). | ||
| $plugin->maturity = MATURITY_STABLE; | ||
| $plugin->supported = [33, 401]; // A range of branch numbers of supported moodle versions. | ||
| $plugin->supported = [405, 500]; // A range of branch numbers of supported moodle versions. |
There was a problem hiding this comment.
any reason we bump it that high?
There was a problem hiding this comment.
Ah I see you are crating a new branch. New branch should match Moodle branch name. MOODLE_405 should be MOODLE _405_STABLE
There was a problem hiding this comment.
@duyhuynhdev also in a readme file can you please add branch matrix like that https://github.com/catalyst/moodle-tool_dynamic_cohorts?tab=readme-ov-file#versions-and-branches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix up ci.yml