Skip to content

Conversation

cdot65
Copy link
Owner

@cdot65 cdot65 commented Mar 23, 2025

User description

Checklist for This Pull Request

🚨Please adhere to the guidelines for contributing to this repository.

  • Ensure you are submitting your pull request to a branch dedicated to a specific topic/feature/bugfix. Avoid using the master branch for pull requests.
  • Target your pull request to the main development branch in this repository.
  • Ensure your commit messages follow the project's preferred format.
  • Check that your code additions do not fail any linting checks or unit tests.

Pull Request Description

Updating mkdocs page.

What does this pull request accomplish?

  • Documentation update

Are there any breaking changes included?

  • Yes
  • No

Is there anything the reviewers should know?

Thank you for your contributions!


PR Type

Enhancement, Documentation


Description

  • Updated mkdocs configuration for improved features

  • Refined GitHub workflow for Python 3.12 compatibility

  • Added new dependencies for enhanced documentation

  • Improved site aesthetics and navigation structure


Changes walkthrough 📝

Relevant files
Configuration changes
mkdocs-gh-pages.yml
Specify Python 3.12 in GitHub workflow                                     

.github/workflows/mkdocs-gh-pages.yml

  • Updated Python version to 3.12 for compatibility
+1/-1     
Enhancement
mkdocs.yml
Comprehensive update of mkdocs configuration                         

mkdocs.yml

  • Expanded site configuration with new features
  • Added plugins: termynal and autorefs
  • Included markdown extensions for enhanced formatting
  • Customized theme settings and navigation structure
  • +67/-9   
    Dependencies
    pyproject.toml
    Add new mkdocs plugin dependencies                                             

    pyproject.toml

    • Added new dependencies: mkdocs-autorefs and mkdocs-termynal
    +2/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • cdot65 added 2 commits March 23, 2025 11:22
    - Refactored mkdocs.yml to follow project standards and add improved features
    - Added missing dependencies: mkdocs-autorefs and mkdocs-termynal
    - Updated GitHub workflow to use Python 3.12 specifically to avoid compatibility issues
    - Fixed autorefs plugin configuration issue with explicit link_titles setting
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Python Version

    The Python version has been updated to a specific version (3.12). Ensure this version is compatible with all dependencies and the project requirements.

    python-version: "3.12"
    Configuration Complexity

    The mkdocs.yml file has been significantly expanded with new features and configurations. Verify that all new settings are necessary and correctly configured.

    site_name: PAN-OS Upgrade Automation
    site_description: Automate upgrades of Palo Alto Networks firewalls with Python
    site_url: https://cdot65.github.io/pan-os-upgrade/
    repo_name: cdot65/pan-os-upgrade
    repo_url: https://github.com/cdot65/pan-os-upgrade
    site_dir: site
    copyright: Copyright © 2023-2025 Calvin Remsburg
    
    theme:
      name: material
      logo: images/logo.svg
      favicon: images/logo.svg
      language: en
      features:
        - navigation.sections
        - navigation.indexes
        - navigation.top
        - navigation.tabs
        - navigation.tabs.sticky
        - navigation.instant
        - navigation.tracking
        - navigation.footer
        - content.code.copy
        - content.code.annotate
        - content.tabs.link
      palette:
        - scheme: default
          primary: indigo
          accent: indigo
          toggle:
            icon: material/brightness-7
            name: Switch to dark mode
        - scheme: slate
          primary: indigo
          accent: indigo
          toggle:
            icon: material/brightness-4
            name: Switch to light mode
    
    plugins:
      - search
      - termynal
      - autorefs:
          link_titles: true
      - mkdocstrings:
          handlers:
            python:
              options:
                show_source: false
              selection:
                docstring_style: google
    
    markdown_extensions:
      - admonition
      - pymdownx.highlight:
          anchor_linenums: true
          line_spans: __span
          pygments_lang_class: true
      - pymdownx.details
      - pymdownx.inlinehilite
      - pymdownx.snippets
      - pymdownx.superfences
      - pymdownx.tabbed:
          alternate_style: true
      - attr_list
      - md_in_html
      - tables
      - footnotes
    
    # Explicitly set the layout for home page with customizations
    not_in_nav: |
      index.md
    
    extra_css:
      - css/termynal.css
      - css/custom.css
    
    extra_javascript:
      - js/termynal.js
      - js/custom.js
    
    # Define the navigation menu
    nav:
      - Home: index.md
      - User Guide:
          - Introduction: user-guide/introduction.md

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Use flexible Python version specification

    Consider using a more flexible Python version specification to ensure compatibility
    with future minor releases. Instead of pinning to a specific version like "3.12",
    use a version range like "3.12.x" or ">=3.12,<3.13".

    .github/workflows/mkdocs-gh-pages.yml [25-27]

     - name: Setup Python
       uses: actions/setup-python@v4
       with:
    -    python-version: "3.12"
    +    python-version: "3.12.x"
    Suggestion importance[1-10]: 7

    __

    Why: Using a more flexible version specification like "3.12.x" allows for minor updates and patches, improving maintainability without risking compatibility issues.

    Medium
    Update copyright year to present

    The copyright year range is set to end in 2025, which is in the future. It's
    generally recommended to use the current year or a dynamic year that updates
    automatically. Consider updating this to the current year or implementing a dynamic
    solution.

    mkdocs.yml [7]

    -copyright: Copyright &copy; 2023-2025 Calvin Remsburg
    +copyright: Copyright &copy; 2023-2024 Calvin Remsburg
    Suggestion importance[1-10]: 5

    __

    Why: Updating the copyright year to the current year is a good practice for legal accuracy. However, it's a minor change that doesn't significantly impact functionality.

    Low

    - Replaced mkdocs-termynal with the termynal package
    - Added mkdocs core package as an explicit dependency
    - Added the extras option to mkdocstrings for better Python support
    - Removed termynal plugin from mkdocs.yml as it's no longer needed
    - Added pytest-cov and rich for better testing and console output
    @cdot65 cdot65 merged commit b071e05 into main Mar 23, 2025
    1 check passed
    cdot65 added a commit that referenced this pull request Mar 23, 2025
    This version bump includes:
    - Improved assurance logic updates (PR #143)
    - Documentation pipeline updates (PR #146 & #147)
    - Fixes for mkdocs build processes
    cdot65 added a commit that referenced this pull request Mar 23, 2025
    This version bump includes:
    - Improved assurance logic updates (PR #143)
    - Documentation pipeline updates (PR #146 & #147)
    - Fixes for mkdocs build processes
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant