feat: Add Link to Logic View in Options Modal #4046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Review environmenthttps://qjcgggreiveqcefmbcdm5rlrua0uhjpp.lambda-url.ca-central-1.on.aws/ |
...gcforms)/[locale]/(form administration)/form-builder/[id]/edit/components/ModalFormRules.tsx
Show resolved
Hide resolved
| @@ -147,7 +147,9 @@ export const Edit = ({ formId }: { formId: string }) => { | |||
| if (element) { | |||
| const questionNumber = getQuestionNumber(element, elementTypes); | |||
| const item = { ...element, index, questionNumber }; | |||
| return <ElementPanel elements={sortedElements} item={item} key={item.id} />; | |||
| return ( | |||
| <ElementPanel elements={sortedElements} item={item} key={item.id} formId={formId} /> | |||
There was a problem hiding this comment.
Hopefully in the future we can use a react context for situations like this (lots in the app). Just a future refactoring note when/if we get around to refactoring the app state management and definitely something for outside of this PR.
thiessenp-cds
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3976
Passes the formId across the application to be able to route to the logic view - so just a quick test to make sure options don't return "undefined" in the URL at the top.
To test:
-> Open or Create a form.
-> Add a question that can have options.
-> Click an option to show "add rules"
-> Click the "add rules", and then click the "Have a complex form? Try branching instead +"
Double check the form has all the stuff you had, and the URL matches. eg: "en/form-builder/0000/edit" vs "en/form-builder/undefined/edit"