Skip to content

feat: Add dialog 'are you sure' for logic reset. #4051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2024
Merged

feat: Add dialog 'are you sure' for logic reset. #4051

merged 1 commit into from
Jul 23, 2024

Conversation

ShadeWyrm
Copy link
Contributor

Closes #3988

To test:

  1. Open Form
  2. Go to Logic View
  3. Click the Tiny Logic Reset Button
  4. Dialog occurs!~
  5. Cancel to not, Confirm to!

@github-actions GitHub Actions
Copy link
Contributor

🧪 Review environment

https://5jrykpn5bhqjus4d6245n4b7oy0vwlmf.lambda-url.ca-central-1.on.aws/

thiessenp-cds
thiessenp-cds approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@thiessenp-cds thiessenp-cds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Chrome using VoiceOver, works as expected.
Nice work! LGTM :)

@ShadeWyrm ShadeWyrm merged commit 38620a6 into develop Jul 23, 2024
13 checks passed
@ShadeWyrm ShadeWyrm deleted the feat/logic-are-you-sure-check branch July 23, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiessenp-cds thiessenp-cds thiessenp-cds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pop-up to warn about autoflow/reset as a destructive action
2 participants
@ShadeWyrm @thiessenp-cds