fix(dependencies): upgrade mocha to v11 and sinon to v19, added engin… #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es setting to package.json
|
🎉 This PR is included in version 1.0.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…es setting to package.json
@AsifNawaz-cnic
Ok, got it how tests work... Notifications still work and tests completed successfully while the node matrix used in our workflow also supports older versions of nodejs which are no longer compatible with the latest major versions of mocha/sinon.
npx installed-check --engine-check --verboseasked me to add engines.node and to set^21.6.2(just fyi)We still test for node 20 (bad engine error), but tests still complete successfully, so let us ignore that part.