Feature/ci #597
Merged
Feature/ci #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
Signed-off-by: Praveen Asokan <Praveen.Asokan@centrica.com>
| @@ -14,6 +14,11 @@ | |||
|
|
|||
| "run_settings": { | |||
| "cypress_config_file": "./cypress.config.js", | |||
| "cypress_version": "12.15.0", | |||
| "cache_dependencies": "true", | |||
There was a problem hiding this comment.
Suggested change
| "cache_dependencies": "true", | |
| "cache_dependencies": "true", |
| "cypress_version": "12.15.0", | ||
| "cache_dependencies": "true", | ||
| "specs": [ | ||
| "cypress/**/*.feature" |
There was a problem hiding this comment.
Suggested change
| "cypress/**/*.feature" | |
| "cypress/**/*.feature" |
These files seems to be generated from test run. Does it need to included? Or it could be ignored from git commit. |
cucumber-messages.ndjson
Outdated
| @@ -0,0 +1,2 @@ | |||
| {"testRunStarted":{"timestamp":{"seconds":1723452518,"nanos":607000000}}} | |||
There was a problem hiding this comment.
Remove the file and add it to .gitignore.
cucumber-report.html
Outdated
There was a problem hiding this comment.
Remove the file and add it to .gitignore.
npm_install_debug.log
Outdated
There was a problem hiding this comment.
Remove the file and add it to .gitignore.
| @@ -64,11 +63,9 @@ | |||
| "chromatic": "6.17.3", | |||
| "cypress": "12.15.0", | |||
| "cypress-tags": "1.1.2", | |||
| "env-cmd": "^10.1.0", | |||
There was a problem hiding this comment.
remove the package from package-lock.json
MekalaNagarajan-Centrica
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick description
What has been achieved in this pull request?
Related issues
Checklist before merging