Skip to content

Conversation

zmc
Copy link
Member

@zmc zmc commented Apr 2, 2025

No description provided.

@zmc zmc requested a review from dmick April 2, 2025 21:37
Copy link
Member

@dmick dmick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes and test make sense to me. I'm refraining from merge as this is a draft.

@dmick
Copy link
Member

dmick commented Apr 4, 2025

#142 is the associated issue

zmc added 2 commits April 8, 2025 13:45
Signed-off-by: Zack Cerza <zack@cerza.org>
... if other parameters are different. This allows shaman to support pipeline
builds.

Signed-off-by: Zack Cerza <zack@cerza.org>
@zmc
Copy link
Member Author

zmc commented Apr 8, 2025

Tested against a deployed version with a copy of the production db, with @dmick's help. That led to discovery of a small bug (accounting for arch!), and after adding a test for that and updating the feature code, the db tests are showing the desired behavior.

@zmc zmc marked this pull request as ready for review April 8, 2025 19:48
@dmick dmick self-requested a review April 8, 2025 20:05
Copy link
Member

@dmick dmick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to miss that in the first review, but yes, clearly the right addition.

@zmc zmc merged commit e0a3fdf into main Apr 8, 2025
4 checks passed
@zmc zmc deleted the url-test branch April 8, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants