Skip to content

feat: Add speed control #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Add speed control #45

wants to merge 2 commits into from

Conversation

DoozkuV
Copy link

@DoozkuV DoozkuV commented May 31, 2025

This PR allows you to increase or decrease the speed of the audio playback by setting the "playback_speed" variable like what was referenced in #41.

@cheofusi
Copy link
Owner

cheofusi commented Jun 1, 2025

Hi George,

Thank you for the PR!

How did you test this?

@DoozkuV
Copy link
Author

DoozkuV commented Jun 3, 2025

Hello! Thank you for the response. To be honest, I made this PR as I was working on a really simple metronome CLI application and I was frustrated by the lack of extremely simple audio libraries for Python. This one caught my eye, but I saw it didn't have a good speed control option which is why I decide to jump in and implement it myself. It's my first time doing this kind of C/Python FFI work though so apologies if the PR is a bit rough.

Right now there's a SIGSEGV issue when you change the speed around with high numbers, so I'm going to go back in and work on that some more. I'll also try to get some better testing set up because I didn't catch that when I first sent this PR. Thank you for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants