Skip to content

fix: init properties #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2024
Merged

fix: init properties #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a92fc6
fix: only allow init args to be set at construction (and respect expl…
Aug 23, 2024
ddd191c
fix: use static closures
Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...hickensoft.Introspection.Generator.TypeGenerator/A_ChildBaseFullyQualified58F37FBE84.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public class MetatypeMetadata : Chickensoft.Introspection.IMetatype {
public object Construct(System.Collections.Generic.IReadOnlyDictionary<string, object?>? args = null) {
args = args ?? throw new System.ArgumentNullException(nameof(args), "Constructing ChildBaseFullyQualified requires init args.");
return new ChildBaseFullyQualified() {
Identifier = args.ContainsKey("Identifier") ? (string)args["Identifier"] : default!
Identifier = args.ContainsKey("Identifier") ? (string)args["Identifier"] : default(string)!
};
}
[System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
Expand Down
2 changes: 1 addition & 1 deletion ...enerator/Chickensoft.Introspection.Generator.TypeGenerator/AliasedStuff_Nested_Child.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public class MetatypeMetadata : Chickensoft.Introspection.IMetatype {
public object Construct(System.Collections.Generic.IReadOnlyDictionary<string, object?>? args = null) {
args = args ?? throw new System.ArgumentNullException(nameof(args), "Constructing Child requires init args.");
return new Child() {
Identifier = args.ContainsKey("Identifier") ? (string)args["Identifier"] : default!
Identifier = args.ContainsKey("Identifier") ? (string)args["Identifier"] : default(string)!
};
}
[System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
Expand Down
2 changes: 1 addition & 1 deletion ...nerator/Chickensoft.Introspection.Generator.TypeGenerator/AliasedStuff_Nested_Child2.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public class MetatypeMetadata : Chickensoft.Introspection.IMetatype {
public object Construct(System.Collections.Generic.IReadOnlyDictionary<string, object?>? args = null) {
args = args ?? throw new System.ArgumentNullException(nameof(args), "Constructing Child2 requires init args.");
return new Child2() {
Identifier = args.ContainsKey("Identifier") ? (string)args["Identifier"] : default!
Identifier = args.ContainsKey("Identifier") ? (string)args["Identifier"] : default(string)!
};
}
[System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
Expand Down
2 changes: 1 addition & 1 deletion ...hickensoft.Introspection.Generator.TypeGenerator/B_ChildBaseFullyQualifiedF9E7B51DD8.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public class MetatypeMetadata : Chickensoft.Introspection.IMetatype {
public object Construct(System.Collections.Generic.IReadOnlyDictionary<string, object?>? args = null) {
args = args ?? throw new System.ArgumentNullException(nameof(args), "Constructing ChildBaseFullyQualified requires init args.");
return new ChildBaseFullyQualified() {
Identifier = args.ContainsKey("Identifier") ? (string)args["Identifier"] : default!
Identifier = args.ContainsKey("Identifier") ? (string)args["Identifier"] : default(string)!
};
}
[System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
Expand Down
4 changes: 2 additions & 2 deletions ....Generator/Chickensoft.Introspection.Generator.TypeGenerator/BaseClasses_A_BaseClass.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public class MetatypeMetadata : Chickensoft.Introspection.IMetatype {
Name: "Name",
IsInit: true,
IsRequired: true,
Getter: (object obj) => ((BaseClass)obj).Name,
Getter: static (object obj) => ((BaseClass)obj).Name,
Setter: null,
GenericType: new GenericType(
OpenType: typeof(string),
Expand Down Expand Up @@ -57,7 +57,7 @@ public class MetatypeMetadata : Chickensoft.Introspection.IMetatype {
public object Construct(System.Collections.Generic.IReadOnlyDictionary<string, object?>? args = null) {
args = args ?? throw new System.ArgumentNullException(nameof(args), "Constructing BaseClass requires init args.");
return new BaseClass() {
Name = args.ContainsKey("Name") ? (string)args["Name"] : default!
Name = args.ContainsKey("Name") ? (string)args["Name"] : default(string)!
};
}
[System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
Expand Down
2 changes: 1 addition & 1 deletion ...tion.Generator/Chickensoft.Introspection.Generator.TypeGenerator/BaseClasses_B_Child.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public class MetatypeMetadata : Chickensoft.Introspection.IMetatype {
public object Construct(System.Collections.Generic.IReadOnlyDictionary<string, object?>? args = null) {
args = args ?? throw new System.ArgumentNullException(nameof(args), "Constructing Child requires init args.");
return new Child() {
Name = args.ContainsKey("Name") ? (string)args["Name"] : default!
Name = args.ContainsKey("Name") ? (string)args["Name"] : default(string)!
};
}
[System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
Expand Down
2 changes: 1 addition & 1 deletion ...hickensoft.Introspection.Generator.TypeGenerator/C_ChildBaseFullyQualifiedD92201992B.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public class MetatypeMetadata : Chickensoft.Introspection.IMetatype {
public object Construct(System.Collections.Generic.IReadOnlyDictionary<string, object?>? args = null) {
args = args ?? throw new System.ArgumentNullException(nameof(args), "Constructing ChildBaseFullyQualified requires init args.");
return new ChildBaseFullyQualified() {
Identifier = args.ContainsKey("Identifier") ? (string)args["Identifier"] : default!
Identifier = args.ContainsKey("Identifier") ? (string)args["Identifier"] : default(string)!
};
}
[System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
Expand Down
2 changes: 1 addition & 1 deletion ...hickensoft.Introspection.Generator.TypeGenerator/StaticUsings_ChildWithStaticBaseRef.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public class MetatypeMetadata : Chickensoft.Introspection.IMetatype {
public object Construct(System.Collections.Generic.IReadOnlyDictionary<string, object?>? args = null) {
args = args ?? throw new System.ArgumentNullException(nameof(args), "Constructing ChildWithStaticBaseRef requires init args.");
return new ChildWithStaticBaseRef() {
Identifier = args.ContainsKey("Identifier") ? (string)args["Identifier"] : default!
Identifier = args.ContainsKey("Identifier") ? (string)args["Identifier"] : default(string)!
};
}
[System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
Expand Down
2 changes: 1 addition & 1 deletion ...hickensoft.Introspection.Generator.TypeGenerator/TestCases_SetOnlyPropertyE303C8557E.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public class MetatypeMetadata : Chickensoft.Introspection.IMetatype {
IsInit: false,
IsRequired: false,
Getter: null,
Setter: (object obj, object? value) => ((SetOnlyProperty)obj).Value = (string)value!,
Setter: static (object obj, object? value) => ((SetOnlyProperty)obj).Value = (string)value!,
GenericType: new GenericType(
OpenType: typeof(string),
ClosedType: typeof(string),
Expand Down
4 changes: 2 additions & 2 deletions ...hickensoft.Introspection.Generator.TypeGenerator/Tests_TestCases_BaseModel6634CD33B5.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ public class MetatypeMetadata : Chickensoft.Introspection.IMetatype {
Name: "Name",
IsInit: false,
IsRequired: false,
Getter: (object obj) => ((BaseModel)obj).Name,
Setter: (object obj, object? value) => ((BaseModel)obj).Name = (string)value!,
Getter: static (object obj) => ((BaseModel)obj).Name,
Setter: static (object obj, object? value) => ((BaseModel)obj).Name = (string)value!,
GenericType: new GenericType(
OpenType: typeof(string),
ClosedType: typeof(string),
Expand Down
Loading
Loading