Feature/create dataset modal exec #150

DelaunayAlex · 2024-08-07T10:44:23Z

WARNING Merge after #141

nbrouand

Your formatter remove space in each import. Could you fix it please ?

I click edit without changing anything, but it says custom dataset. Do you think it's correct ?
Don't you think it's clear that when we save, we do not override current dataset values ? SHould we add another checkbox to override updated dataset ?

I cannot save a dataset anymore

And i cannot edit dataset, i am always redirect on this url :
https://localhost:4200/#/dataset/undefined/edition

.../main/java/com/chutneytesting/server/core/domain/execution/ScenarioExecutionEngineAsync.java

...erver-core/src/main/java/com/chutneytesting/server/core/domain/scenario/ExternalDataset.java

chutney/server/src/main/java/com/chutneytesting/dataset/api/DataSetMapper.java

...ney/server/src/main/java/com/chutneytesting/execution/api/CampaignExecutionUiController.java

...rver/src/main/java/com/chutneytesting/execution/domain/campaign/CampaignExecutionEngine.java

...er/src/main/java/com/chutneytesting/execution/infra/storage/jpa/ScenarioExecutionEntity.java

nbrouand

The message " Le nom du dataset est vide " should appear only on click on "execute"

The dataset name input could be wider now

When i am on campaign history :

When i replay last campaign execution :

chutney/ui/src/app/shared/components/dataset/forms-data-grid/forms-data-grid.component.html

chutney/ui/src/app/modules/scenarios/services/scenario-execution.service.spec.ts

chutney/ui/src/app/core/model/external-dataset.model.ts

chutney/ui/src/app/core/model/dataset.model.ts

...e/src/main/java/com/chutneytesting/server/core/domain/scenario/campaign/TestCaseDataset.java

...src/main/java/com/chutneytesting/server/core/domain/dataset/ExternalDatasetEntityMapper.java

...ney/server/src/main/java/com/chutneytesting/execution/api/CampaignExecutionUiController.java

...rver/src/main/java/com/chutneytesting/execution/domain/campaign/CampaignExecutionEngine.java

.../src/test/java/com/chutneytesting/execution/domain/campaign/CampaignExecutionEngineTest.java

chutney/server/src/test/java/com/chutneytesting/tools/ExternalDatasetEntityMapperTest.java

nbrouand · 2024-08-28T13:01:15Z

Use constants and datable from report instead of store them in database

nbrouand · 2024-09-03T12:46:19Z

show errror message on click on execute not directly when we click inside the intput

nbrouand · 2024-09-03T12:47:54Z

do not enable execute button while loading environment because if we are too fast we can click before the component is fully loaded and it leads to an error.

nbrouand · 2024-09-03T12:49:00Z

when I click on "new dataset"

chutney/server/src/main/resources/changelog/db.changelog-master.xml

…aset information for scenario execution

…on required field, Fix request object in scenario exec ws

… while saving dataset in modal, fix bug dataset info in report

…rite

boddissattva · 2024-09-12T10:01:19Z

When i execute a scenario with a named dataset, i got Custom as dataset name in report.

boddissattva · 2024-09-12T12:32:20Z

On campaign edition, strange error message

boddissattva · 2024-09-12T12:41:20Z

If we allow this

There could be some clash in campaign report !! (but scenario executions are ok)

On campaign edition, if a scenario is selected multiple times, every selection has to have a dataset set.

boddissattva · 2024-09-12T12:57:19Z

In campaign report export, we have

Could be good to keep the name for the moment ? And add a task for adding the dataset content used.

boddissattva · 2024-09-12T13:18:28Z

When i click on a dataset filter value, it unchecks itself automagically !! So can't select a dataset filter at all.

…ser did not modify the dataset in exec modal

nbrouand · 2024-09-16T08:54:14Z

Bug:
create a campaign with a dataset
save
update the campaign by removing the dataset
run => error

boddissattva · 2024-09-16T09:21:05Z

I got some executions on a given scenario

When i set a default dataset on this scenario, all the old executions without dataset show the use of the default dataset

Do we have to keep the default dataset declaration on scenarios ?

When i put this scenario (with a default dataset) in a campaign (without a default dataset) and execute the campaign manually without a dataset, the scenario default dataset is not used.
The same thing happens for a planified campaign execution.

Note :

The dataset filter seems to filter correctly the scenario's executions.
When i execute a campaign (with default dataset) manually without a dataset, the default dataset is used.

nbrouand · 2024-09-16T09:25:08Z

bug: import/export on dataset not present anymore

...src/main/java/com/chutneytesting/server/core/domain/scenario/campaign/CampaignExecution.java

...ney/server/src/main/java/com/chutneytesting/execution/api/CampaignExecutionUiController.java

...y/server/src/main/java/com/chutneytesting/execution/infra/execution/DatasetEntityMapper.java

.../main/java/com/chutneytesting/execution/infra/storage/jpa/ScenarioExecutionReportEntity.java

boddissattva · 2024-09-17T09:34:12Z

When i save a campaign, i got an error

… rules

DelaunayAlex self-assigned this Aug 7, 2024

DelaunayAlex marked this pull request as draft August 7, 2024 10:44

DelaunayAlex added the enhancement New feature or request label Aug 7, 2024

DelaunayAlex force-pushed the feature/create_dataset_modal_exec branch 3 times, most recently from 0b9add9 to c7f9f43 Compare August 11, 2024 23:59

DelaunayAlex force-pushed the feature/create_dataset_modal_exec branch 5 times, most recently from fc3d77c to 728b625 Compare August 22, 2024 15:02

DelaunayAlex marked this pull request as ready for review August 26, 2024 15:06

DelaunayAlex requested review from nbrouand, KarimGl, rbenyoussef and boddissattva August 26, 2024 15:06

DelaunayAlex force-pushed the feature/create_dataset_modal_exec branch 2 times, most recently from 9fa1c37 to 58ad3a6 Compare August 27, 2024 09:08

nbrouand requested changes Aug 27, 2024

View reviewed changes

KarimGl reviewed Aug 27, 2024

View reviewed changes

nbrouand reviewed Aug 27, 2024

View reviewed changes

nbrouand reviewed Aug 28, 2024

View reviewed changes

DelaunayAlex force-pushed the feature/create_dataset_modal_exec branch 3 times, most recently from e8f884f to 30891ab Compare September 3, 2024 12:12

nbrouand reviewed Sep 3, 2024

View reviewed changes

chutney/server/src/main/resources/changelog/db.changelog-master.xml Outdated Show resolved Hide resolved

DelaunayAlex and others added 7 commits September 11, 2024 16:06

feat(server, ui): Fix PR, fix error console UI, use report to get dat…

921c15d

…aset information for scenario execution

feat(server, ui): Unsubscribe to observable, fix test

763a74a

feat(server, ui): Rebase + clean PR

ef34b87

feat(server, ui): Fix error console UI, error in modal after touched …

bd04ee7

…on required field, Fix request object in scenario exec ws

feat(ui): change type datatable/constant in db, display error message…

2d138cf

… while saving dataset in modal, fix bug dataset info in report

wip(server) : fix scenario execution without dataset - unit test to w…

91abd33

…rite

feat(server): Fix PR, use DATASET_ID in ScenarioExecution, fix bug UI

c85e7df

DelaunayAlex force-pushed the feature/create_dataset_modal_exec branch from 41928b8 to c85e7df Compare September 11, 2024 14:10

feat(server): Fix tests

16a0e52

DelaunayAlex added 3 commits September 13, 2024 08:29

feat(server): Fix tests

6df6d76

feat(server): Fix table with dataset name

350a98c

feat(server): Fix dataset filter in campaign, use saved scenario if u…

48c7399

…ser did not modify the dataset in exec modal

nbrouand reviewed Sep 16, 2024

View reviewed changes

feat(server): Fix PR, fix blank dataset in campaign, fix bug UI

fe05762

DelaunayAlex force-pushed the feature/create_dataset_modal_exec branch from 8179574 to fe05762 Compare September 17, 2024 07:30

DelaunayAlex added 2 commits September 17, 2024 11:37

feat(server): Fix dataset id verification, check undefined

cf12104

feat(server): Refacto CampaignExecution, rename tests to explicit the…

8221ad6

… rules

boddissattva approved these changes Sep 17, 2024

View reviewed changes

nbrouand approved these changes Sep 17, 2024

View reviewed changes

nbrouand merged commit 2bcbd70 into main Sep 17, 2024
3 checks passed

nbrouand deleted the feature/create_dataset_modal_exec branch September 17, 2024 14:30

Feature/create dataset modal exec #150

Feature/create dataset modal exec #150

Uh oh!

Conversation

DelaunayAlex commented Aug 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nbrouand left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nbrouand left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nbrouand commented Aug 28, 2024

Uh oh!

nbrouand commented Sep 3, 2024

Uh oh!

nbrouand commented Sep 3, 2024

Uh oh!

nbrouand commented Sep 3, 2024

Uh oh!

Uh oh!

boddissattva commented Sep 12, 2024

Uh oh!

boddissattva commented Sep 12, 2024

Uh oh!

boddissattva commented Sep 12, 2024

Uh oh!

boddissattva commented Sep 12, 2024

Uh oh!

boddissattva commented Sep 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nbrouand commented Sep 16, 2024

Uh oh!

boddissattva commented Sep 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nbrouand commented Sep 16, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

boddissattva commented Sep 17, 2024

Uh oh!

Uh oh!

Uh oh!

DelaunayAlex commented Aug 7, 2024 •

edited

Loading

nbrouand left a comment •

edited

Loading

boddissattva commented Sep 12, 2024 •

edited

Loading

boddissattva commented Sep 16, 2024 •

edited

Loading