Skip to content

Conversation

lread
Copy link
Collaborator

@lread lread commented Apr 18, 2025

Etaoin uses cheshire which uses jackson.
Jackson implemented, for security reasons, processing limits. Starting with cheshire 6.0.0 these jackson limits are configurable.

The default json input string length for jackson is 20mb. This is small for Etaoin, a webdriver will return a base64 encoded pdf for a print page request.
We've bumped the json input string limit to ~2gb.

Closes #691

Please complete and include the following checklist:

  • I have read CONTRIBUTING and the Etaoin Developer Guide.

  • This PR corresponds to an issue that the Etaoin maintainers have agreed to address.

  • This PR contains test(s) to protect against future regressions (the existing json parse error test should suffice)

  • I have updated CHANGELOG.adoc with a description of the addressed issue.

Etaoin uses cheshire which uses jackson.
Jackson implemented, for security reasons, processing limits.
Starting with cheshire 6.0.0 these jackson limits are configurable.

The default json input string length for jackson is 20mb.
This is small for Etaoin, a webdriver will return a base64 encoded pdf
for a print page request.
We've bumped the json input string limit to ~2gb.

Closes #691
@lread lread merged commit ce7390b into master Apr 18, 2025
105 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

print-page fails sometimes - reason: hidden json-parse errror on large content
1 participant