Allow for large json strings in webdriver response #699
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Etaoin uses cheshire which uses jackson.
Jackson implemented, for security reasons, processing limits. Starting with cheshire 6.0.0 these jackson limits are configurable.
The default json input string length for jackson is 20mb. This is small for Etaoin, a webdriver will return a base64 encoded pdf for a print page request.
We've bumped the json input string limit to ~2gb.
Closes #691
Please complete and include the following checklist:
I have read CONTRIBUTING and the Etaoin Developer Guide.
This PR corresponds to an issue that the Etaoin maintainers have agreed to address.
This PR contains test(s) to protect against future regressions (the existing json parse error test should suffice)
I have updated CHANGELOG.adoc with a description of the addressed issue.