Skip to content

Conversation

lread
Copy link
Collaborator

@lread lread commented Aug 8, 2025

Please complete and include the following checklist:

  • I have read CONTRIBUTING and the Etaoin Developer Guide.

  • This PR corresponds to an issue that the Etaoin maintainers have agreed to address.

  • This PR contains test(s) to protect against future regressions

  • I have updated CHANGELOG.adoc with a description of the addressed issue.

@lread
Copy link
Collaborator Author

lread commented Aug 8, 2025

MacOS Safari and Windows Firefox seem to be flakier than I remember.

Haven't got Windows Firefox to pass yet.
I'll dust off my Windows VM and see if I can reproduce the failures.

By default, clojure writes unexpected exceptions to a file.
This is not helpful for tests running on ci.
Ask clojure to write the exception to the console.
@lread lread changed the title maint: bump deps maint: bump deps & misc tweaks Aug 8, 2025
@lread
Copy link
Collaborator Author

lread commented Aug 9, 2025

Increasing the ETAOIN_TIMEOUT to 4 minutes seems to have fixed the Windows Firefox failures.

Safari is still flaky, but that's nothing new. Not sure if it is more flaky, but retrying the failed CI job can lead to success.

Increase to a very generous 4 minutes.
This actually has helped with your Firefox Windows timeout errors.

Contributes to #465
@lread lread force-pushed the lread/maint-2025-08-08 branch from 38bacfb to 6fda77b Compare August 9, 2025 01:19
@lread
Copy link
Collaborator Author

lread commented Aug 9, 2025

I'll dust off my macOS dev env on my wife's MacBook tomorrow and take a peek at Safari failures.
The biggest culprit for failures from CI runs for this PR is test-switch-window-next.

@lread lread merged commit 2f1a4ba into master Aug 9, 2025
105 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant