fix(chore) Disable redirects in wget and curl commands #2998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalan316
changed the title
asalan316
added
the
allow-acceptance-tests
asalan316
force-pushed
the
chore-remove-wget-vulnerabilites
branch
2 times, most recently
from
6a389e5 to
93b62a5
Compare
asalan316
commented
Jun 7, 2024
| @@ -64,22 +64,22 @@ RUN apt-get update && \ | |||
| # Install bosh_cli | |||
| # renovate: datasource=github-releases depName=bosh-cli lookupName=cloudfoundry/bosh-cli | |||
| ARG BOSH_VERSION=7.5.7 | |||
| RUN wget -q https://github.com/cloudfoundry/bosh-cli/releases/download/v${BOSH_VERSION}/bosh-cli-${BOSH_VERSION}-linux-amd64 && \ | |||
| RUN wget --secure-protocol=TLSv1_2 --max-redirect=1 -q https://github.com/cloudfoundry/bosh-cli/releases/download/v${BOSH_VERSION}/bosh-cli-${BOSH_VERSION}-linux-amd64 && \ | |||
There was a problem hiding this comment.
allow max 1 redirect as cloudfoundry cli available on objects.githubusercontent.com
asalan316
force-pushed
the
chore-remove-wget-vulnerabilites
branch
3 times, most recently
from
5a04ebc to
9deea1d
Compare
asalan316
force-pushed
the
chore-remove-wget-vulnerabilites
branch
from
9deea1d to
bf32048
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using wget and curl in Dockerfile, the usage of HTTPS is not enforced. This might lead to redirect to vulnerable/insecure websites via HTTP traffic
Fix
Enforce HTTPs and disabling redirects.
Reported by SonarQube