feat: add pod identity association support for EKS addons #256

litanyofmadness · 2025-07-25T21:15:37Z

what

Added pod_identity_association parameter to EKS addons configuration
Maps service account names to IAM role ARNs for pod identity authentication
Maintains backward compatibility with existing configurations

why

Enables modern IAM authentication for EKS addons using pod identities
Aligns with AWS best practices for EKS

references

Terraform EKS Addon Pod Identity: Docs
Closes: #252

coderabbitai · 2025-07-25T21:15:46Z

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

The changes introduce support for the pod_identity_association block in EKS addon configuration. This is achieved by updating the Terraform module to allow specifying a map of service accounts and IAM role ARNs per addon, and by modifying the variable definitions to accept this new configuration option.

Changes

Files	Change Summary
main.tf	Added a dynamic `pod_identity_association` block to the `aws_eks_addon` resource, iterating over a new map input.
variables.tf	Added an optional `pod_identity_association` attribute (type `map(string)`) to the `addons` variable definition.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Complexity: Simple addition of a dynamic block and variable schema extension; no complex logic or refactoring involved.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (2)

variables.tf (1)
175-180: Add an explanatory comment for the new attribute

pod_identity_association is a brand-new field and its purpose is not obvious from the surrounding context. A one-line comment (in the same style as the neighbouring attributes) will make the intent clear for future maintainers and keep the object definition self-documenting.
-    pod_identity_association    = optional(map(string), {})
+    # Map of <service_account> => <role_arn> pairs used to create
+    # `pod_identity_association` blocks inside `aws_eks_addon`
+    pod_identity_association    = optional(map(string), {})
main.tf (1)

181-184: Optional: expose namespace when addons are not in kube-system

The nested block allows only service_account and role_arn, which works for addons living in kube-system.
Some AWS-managed addons (or future custom ones) run in other namespaces. Consider extending the variable to accept an object { namespace = "foo", role_arn = "…" } for maximum flexibility.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d4b33d8 and 281db86.

📒 Files selected for processing (2)

main.tf (1 hunks)
variables.tf (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Summary

main.tf

oycyc · 2025-08-03T12:36:39Z

/terratest

oycyc · 2025-08-03T12:38:49Z

Good addition, thanks @litanyofmadness !

litanyofmadness · 2025-08-03T13:45:45Z

@oycyc, thanks for reviewing my PR.

I've bumped the Kubernetes version and Kubernetes Go packages in tests to fix this error:

InvalidParameterException: The requested Kubernetes version "1.29" is only supported under extended support. Please change the supportType to extended support to create the cluster.

I'm unsure if it works, so I would appreciate any help.

oycyc · 2025-08-04T01:35:16Z

/terratest

oycyc · 2025-08-04T15:46:31Z

/terratest

oycyc

Agh that's annoying. If this doesn't work, let me try to loop someone in from CloudPosse

oycyc · 2025-08-04T16:19:54Z

Thanks for fixing the tests @litanyofmadness !!

github-actions · 2025-08-04T16:22:41Z

These changes were released in v4.7.0.

feat: add pod identity association support for EKS addons

281db86

litanyofmadness requested review from a team as code owners July 25, 2025 21:15

litanyofmadness requested review from joe-niland and nitrocode July 25, 2025 21:15

mergify bot added the triage Needs triage label Jul 25, 2025

coderabbitai bot reviewed Jul 25, 2025

View reviewed changes

main.tf Outdated Show resolved Hide resolved

litanyofmadness added 2 commits July 25, 2025 17:29

fix: minor update for coderabbit

dcc964b

chore: bump aws provider version

9ca4517

yhrunykRW approved these changes Jul 26, 2025

View reviewed changes

oycyc previously approved these changes Aug 3, 2025

View reviewed changes

oycyc added minor New features that do not break anything feature New functionality and removed triage Needs triage labels Aug 3, 2025

oycyc enabled auto-merge (squash) August 3, 2025 12:39

chore: bump kubernetes version from 1.29 to 1.33 in tests

96f30d3

auto-merge was automatically disabled August 3, 2025 13:17
Head branch was pushed to by a user without write access

litanyofmadness dismissed oycyc’s stale review via 96f30d3 August 3, 2025 13:17

chore: update kubernetes go client libraries in tests

a8f6753

litanyofmadness requested a review from oycyc August 3, 2025 14:13

chore: update ami type in tests

be18af2

litanyofmadness requested a review from yhrunykRW August 4, 2025 12:58

oycyc reviewed Aug 4, 2025

View reviewed changes

oycyc approved these changes Aug 4, 2025

View reviewed changes

oycyc merged commit 78ee99b into cloudposse:main Aug 4, 2025
16 checks passed

Uh oh!

feat: add pod identity association support for EKS addons #256

feat: add pod identity association support for EKS addons #256

Uh oh!

Conversation

litanyofmadness commented Jul 25, 2025

what

why

references

Uh oh!

coderabbitai bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

oycyc commented Aug 3, 2025

Uh oh!

oycyc commented Aug 3, 2025

Uh oh!

litanyofmadness commented Aug 3, 2025

Uh oh!

oycyc commented Aug 4, 2025

Uh oh!

oycyc commented Aug 4, 2025

Uh oh!

oycyc left a comment

Choose a reason for hiding this comment

Uh oh!

oycyc commented Aug 4, 2025

Uh oh!

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

Uh oh!

coderabbitai bot commented Jul 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)