Skip to content

refactor: finfo_close automatically freed in PHP 8.5 #9684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 4.7
Choose a base branch
from
Open

refactor: finfo_close automatically freed in PHP 8.5 #9684

wants to merge 1 commit into from
+4 −1

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Aug 14, 2025

Description
Based php/php-src#18396 and related to #9664

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added enhancement PRs that improve existing functionalities 4.7 refactor Pull requests that refactor code and removed enhancement PRs that improve existing functionalities labels Aug 14, 2025
michalsn
michalsn reviewed Aug 14, 2025
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use unset() instead?

@ddevsr ddevsr mentioned this pull request Aug 14, 2025
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn left review comments

Assignees
No one assigned
Labels
4.7 refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddevsr @michalsn