feat: add coderd_organization_group_sync resource
#248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ethanndickson
changed the title
coderd_organization_group_sync_resourcecoderd_organization_group_sync resource
ethanndickson
force-pushed
the
ethan/group-sync-resource
branch
from
f7c7ea3 to
2fb0bd4
Compare
deansheather
approved these changes
Aug 15, 2025
aslilac
reviewed
Aug 15, 2025
There was a problem hiding this comment.
looking at the code again, I'm remember the main motivation for making this a nested block: you can only have exactly one group sync config per organization. managing it by a resource instead means that you could theoretically specify multiple of them pointing at the same org, which would be a logic error and produce inconsistent behavior. :\
it's unfortunate that having it as a nested block doesn't work.
| - `group_sync` (Block, Optional) Group sync settings to sync groups from an IdP. (see [below for nested schema](#nestedblock--group_sync)) | ||
| - `group_sync` (Block, Optional, Deprecated) Group sync settings to sync groups from an IdP. | ||
|
|
||
| ~> **Deprecated** This block is deprecated. Use the `coderd_organization_group_sync` resource instead. (see [below for nested schema](#nestedblock--group_sync)) |
There was a problem hiding this comment.
can the "see below" bit stay attached up above? this positioning feels weird
|
|
||
| data "coderd_organization" "test_data" { | ||
| id = coderd_organization.test.id | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } | |
missing \n
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #230.
To avoid users running into circular dependency issues with the
group_syncblock, we'll deprecate the block and add a resource solely for configuring organization group sync.