-
Notifications
You must be signed in to change notification settings - Fork 0
Issue 6 create log in form #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…, modifying existing shadcn/ui template to match Transplant AU brand colours.
…ed in globals.css
…the Figma design. Spacing and typography styling to be done.
…desktop light-mode). Still needs some tweaking to look exactly the same.
…asses. Updated colours and fonts and added Separator component. Desktop light-mode looks very similar to Figma design.
…icable (i.e., py-[12px] becomes py-3)
…or max-width for mobile)
…margins on separator to work for both login and sign-up pages. Design is responsive and matches Figma for both desktop and mobile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good overall, just some minor changes encouraging best practices might be worth going over
…emi-bold weights. Added radius size back as required for radius classes.
… removed font import as defined in globals.css
…ks to correctly navigate to sign-up/login page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yippeee!!! looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Change Summary
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
Other Information
[Is there anything in particular in the review that I should be aware of?]