Skip to content

Issue 6 create log in form #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 10, 2025
Merged

Issue 6 create log in form #37

merged 17 commits into from
Jul 10, 2025

Conversation

nicostellar
Copy link
Contributor

Change Summary

  • Used sign-up form as a template to make the login form.
  • Login page matches Figma design for both desktop and mobile.

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Other Information

[Is there anything in particular in the review that I should be aware of?]

…, modifying existing shadcn/ui template to match Transplant AU brand colours.
…the Figma design. Spacing and typography styling to be done.
…desktop light-mode). Still needs some tweaking to look exactly the same.
…asses. Updated colours and fonts and added Separator component. Desktop light-mode looks very similar to Figma design.
…margins on separator to work for both login and sign-up pages. Design is responsive and matches Figma for both desktop and mobile.
Copy link
Collaborator

@MahitGtg MahitGtg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good overall, just some minor changes encouraging best practices might be worth going over

@MahitGtg MahitGtg mentioned this pull request Jul 2, 2025
4 tasks
@nicostellar
Copy link
Contributor Author

The updated/merged colour palette looks like this:

Light mode:
light-colour-labels

Dark mode:
dark-colour-labels

…ks to correctly navigate to sign-up/login page
@nicostellar nicostellar requested a review from laurenpudz July 10, 2025 10:28
Copy link
Contributor

@laurenpudz laurenpudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yippeee!!! looks great!

Copy link
Collaborator

@MahitGtg MahitGtg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@laurenpudz laurenpudz merged commit 59339fb into main Jul 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants