-
Notifications
You must be signed in to change notification settings - Fork 0
Issue 14 create model for registrant details #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work but a few issues.
Additionally there appears to be some confusion between "blank=True" and "null=True".
- "blank=True" Allows forms to be submitted without this field filled.
- "null=True" Allows the value of a field to be NULL in the database (as an alternative to an empty string)
All user-submitted fields should have "blank=True". "none=True" is only necessary when we want to distinguish between fields that haven't been filled yet and those left intentionally blank.
Do I need to add "null=True" to any fields? |
Null is useful for when a field doesn't have a meaningful "not submitted" value. So it's not really necessary for charfields because they can be an empty string, but it's useful for dates or Booleans because otherwise they're forced to be a random date, or True or False. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done Fiona. This looks ready to merge!
Change Summary
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
Other Information
Related issue