Skip to content

Issue 14 create model for registrant details #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 11, 2025

Conversation

fifibox
Copy link
Contributor

@fifibox fifibox commented Jul 5, 2025

Change Summary

  • created RegistrantDetail model and a placeholder Registration model
  • registered the model in admin site

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Other Information

127 0 0 1_8000_admin_event_registration_registrantdetail_add_(Nest Hub Max)

Related issue

@fifibox fifibox changed the title Issue 14 create registration form backend Issue 14 create model for registrant details Jul 5, 2025
Copy link
Contributor

@SafetyInObscurity SafetyInObscurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work but a few issues.

Additionally there appears to be some confusion between "blank=True" and "null=True".

  • "blank=True" Allows forms to be submitted without this field filled.
  • "null=True" Allows the value of a field to be NULL in the database (as an alternative to an empty string)

All user-submitted fields should have "blank=True". "none=True" is only necessary when we want to distinguish between fields that haven't been filled yet and those left intentionally blank.

@fifibox fifibox requested a review from SafetyInObscurity July 7, 2025 13:40
@fifibox
Copy link
Contributor Author

fifibox commented Jul 7, 2025

Do I need to add "null=True" to any fields?

@SafetyInObscurity
Copy link
Contributor

Do I need to add "null=True" to any fields?

Null is useful for when a field doesn't have a meaningful "not submitted" value. So it's not really necessary for charfields because they can be an empty string, but it's useful for dates or Booleans because otherwise they're forced to be a random date, or True or False.

Copy link
Contributor

@SafetyInObscurity SafetyInObscurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done Fiona. This looks ready to merge!

@fifibox fifibox merged commit 0fea7ff into main Jul 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create model for registrant details
2 participants