-
Notifications
You must be signed in to change notification settings - Fork 2
Add support for CC-NEWS and validation for crawl reference on the CLI interface #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…sn't exist and cc-downloader downloaded the body of the response Now this action will produce an error
…the 4XX error message when downloading paths, adds validation to the cli input for the crawl reference
… automatically fix the casing of the crawl reference
CC-NEWS support and validation for crawl reference
…d files and updated the README.md in order to prepare the next release
@thunderpoot, don't accept or review the PR yet, the
I think it is going to get fixed soon: But this is indeed a problem. I'm thinking of including the
|
… the reqwest deprecated API TODO: We need to monitor the the open PRs in reqwest-middleware and bump the version of it here as soon as they are merged
@thunderpoot It should be safe to review now. I'll track the PR on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Nice error messaging, and fantastic that it supports my laziness (not typing CC-MAIN or CC-NEWS in all caps). Approved 💯
Description
This PR introduces support for CC-NEWS and adds validations for the crawl or snapshot references. This PR also updates some libraries and bumps the rust edition to 2024 and the latest 1.85 version. It also bumps the library version to
0.6.0
.Breaking Changes
No Breaking changes
Notes & open questions
This PR closes issues #8 and #10.