Modernize cmake syntax #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If it is explicitly set to the empty string, it was reset to a value.
The `\t` is variable width, so a fixed set of spaces is better here.
Not sure this is the right fix, but address the cmake issue. Shocking that this was merged without even a basic check!
pqAbstractItemViewEventPlayerBase now supports looking up an item's row/column number using header label. This makes it a little easier to write tests that are not susceptible to minor changes in column / row order.
This prepares the library to support `QT_NO_KEYWORDS`.
* explicit the failing event (object - command - args) so it is easier to find it in the input file.
7c51fc1 Fix a small issue with QRegularExpression a5abdf7 Adding doc 39962b2 Fix some C++17 code 5e3f129 Fixup cmake a1fd62e Support building QtTesting as a separate lib be39159 Fix some emit keywords 4cd2ebc Use UTF8 printable format for error message strings fd51b94 Add context for play error messages ... Acked-by: Kitware Robot <kwrobot@kitware.com> Reviewed-by: Nicolas Vuaille <nicolas.vuaille@kitware.com> Merge-request: !68
- Add a "Dashboard Mode" checkbox in the record dialog - Add an API to enable and be triggered when recording/playing test and toggling the new checkbox. - Add a new misc event "dashboard_mode" to be recorded and played when needed Do not implement any logic behind the dashboard mode as it it very application specific
5115a14 Adding logic for dashboard mode Acked-by: Kitware Robot <kwrobot@kitware.com> Reviewed-by: Nicolas Vuaille <nicolas.vuaille@kitware.com> Merge-request: !69
a53b541 Fixup dashboard mode to update correctly Acked-by: Kitware Robot <kwrobot@kitware.com> Reviewed-by: Nicolas Vuaille <nicolas.vuaille@kitware.com> Merge-request: !70
f9d1da7 Increase cmake min ver to avoid warnings Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !71
* Only one will be selected but it also allow for clear selection
c3578ed Allow setSelection for itemView in Single mode Acked-by: Kitware Robot <kwrobot@kitware.com> Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com> Merge-request: !73
* The pqEventComment records with nullptr
573748b Recorder should handle nullptr object Acked-by: Kitware Robot <kwrobot@kitware.com> Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com> Merge-request: !74
317f4cf enable simple CI Acked-by: Kitware Robot <kwrobot@kitware.com> Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com> Merge-request: !75
This is old, but is what ParaView is using today.
* Restore full control from environment variable
a296854 Remove debug statement Acked-by: Kitware Robot <kwrobot@kitware.com> Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com> Merge-request: !77
edb187d Fix a few warnings Acked-by: Kitware Robot <kwrobot@kitware.com> Reviewed-by: Nicolas Vuaille <nicolas.vuaille@kitware.com> Merge-request: !78
``` grep -rl "See License_v1.2.txt for the full ParaView license." >files.out cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\A\/\*=========================================================================\n\n.*Program.*\n.*Module.*\n\n.*Copyright \(c\) .* Sandia Corporation, Kitware Inc.\n.*All rights reserved.\n.*\n.*\n.*\n.*\n.*See License_v1.2.txt.*\n.*\n.*\n.*\n.*\n.*\n.*\nTHIS.*\n.*EXPRESS.*\nLIMITED.*\n.*PARTICULAR.*\n.*CONTRIBUTORS.*\n.*EXEMPLARY.*\n.*PROCUREMENT.*\n.*PROFITS.*\n.*LIABILITY.*\n.*NEGLIGENCE.*\n.*SOFTWARE.*\n.*\n=*\*\//\/\/ SPDX-FileCopyrightText: Copyright (c) Kitware Inc.\n\/\/ SPDX-FileCopyrightText: Copyright (c) Sandia Corporation\n\/\/ SPDX-License-Identifier: BSD-3-Clause/g' %s ```
Manual replacement
349eefb pqEventTranslator: fix typos in comments 0143b15 qt6: adapt for `QMouseEvent::globalPos` deprecation 3576767 qt6: adapt for `Q*Event::pos` deprecation f13bec5 qt6: adapt for deprecation of `QMouseEvent` ctor without globalPos Acked-by: Kitware Robot <kwrobot@kitware.com> Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com> Merge-request: !80
Add a new superclass for Players: pqBasicObjectPlayer. It defines the API and supports pqcheck event on QObject (instead of the QWidget restriction in pqBasicWidgetEventPlayer), looking for a QObject::property matching the "command" argument.
8d2b229 Allow to check QObject properties Acked-by: Kitware Robot <kwrobot@kitware.com> Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com> Merge-request: !81
This class was added in 8d2b229 but the header was not installed correctly.
Install missing pqObjectPlayer header See merge request paraview/qttesting!83
Also, effectively utilize foundMatch again.
0305e48 Fix segfault when lastObject is nullptr Acked-by: Kitware Robot <kwrobot@kitware.com> Reviewed-by: Nicolas Vuaille <nicolas.vuaille@kitware.com> Merge-request: !85
```bash pip3 install gersemi gersemi -i $(find . -name "*.cmake" -o -name "CMakeLists.txt") ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch applies a code beautifier for CMake syntax to the entire project. It has only cosmetic changes to make the formatting aligned with modern cmake recommendations.