fix: klaviyo actions orgIds [INTEG-3018] #10056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ecommerce-app-base-components canceled.
|
sam-is-content
changed the title
primeinteger
approved these changes
Aug 8, 2025
| const APP_ORGANIZATION_ID = '5EJGHo8tYJcjnEhYWDxivp'; | ||
| const APP_DEFINITION_ID = '2x4lsvuxPAGS2UUHwWVYee'; | ||
|
|
||
| export const getOrgIdForSdk = (sdk: any) => { |
There was a problem hiding this comment.
The sdk param could use a proper type
Suggested change
| export const getOrgIdForSdk = (sdk: any) => { | |
| export const getOrgIdForSdk = (sdk: ConfigAppSDK) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the sdk.ids.orgId refers to the current orgId but when we search for app actions, we need to search for the org where the app action lives. This code makes sure we use the correct org - if the app is the marketplace version, use the marketplace apps org, if this is a custom version, use the current orgId.
I was worried about exposing the orgId but Tyler said they are already exposed in our api calls so whatevs