-
Notifications
You must be signed in to change notification settings - Fork 768
feat: add verbose logging to e2e and interchain test suites #3810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@DeVikingMark lint failing |
@aljo242 thanks for the review, I went through and cleaned up those issues. Got rid of the security warnings by removing the reflect/runtime imports in the chainsuite. Was using them to get suite names but honestly it was overkill - now just parsing the test name directly which works fine and doesn't trigger any warnings. The e2e_test.go file was a mess - same logging pattern duplicated in every single test. Refactored it into one helper function since they were all doing identical start/pass/fail logging anyway. Should be much easier to work with now. Everything should build without the lint errors now. The verbose logging is still there, just implemented better. |
looks like there is one more lint error. tagging @vladjdk to validate if this addresses the linked issue |
@DeVikingMark still lint issues |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
Closes: #3580
Adds comprehensive verbose logging to e2e and interchain test suites to track test execution progress and provide clear pass/fail status.
Changes:
e2e_test.go
with standardized start/pass/fail/skip messagesSetupSuite()
andTearDownSuite()
logging ine2e_setup_test.go
BeforeTest
,AfterTest
, etc.) inchainsuite/suite.go
with smart suite name detectionAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump) - N/A: No breaking changes.changelog
(for details, see contributing guidelines)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change