Skip to content

Conversation

DeVikingMark
Copy link

Description

Closes: #3580

Adds comprehensive verbose logging to e2e and interchain test suites to track test execution progress and provide clear pass/fail status.

Changes:

  • E2E Tests: Added verbose logging to all 16 test methods in e2e_test.go with standardized start/pass/fail/skip messages
  • E2E Suite Lifecycle: Enhanced SetupSuite() and TearDownSuite() logging in e2e_setup_test.go
  • Interchain Tests: Implemented testify suite hooks (BeforeTest, AfterTest, etc.) in chainsuite/suite.go with smart suite name detection

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump) - N/A: No breaking changes
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification - Issue Make testing more verbose #3580
  • Followed the guidelines for building SDK modules - N/A: Test-only changes
  • Included the necessary unit and integration tests - Changes enhance existing tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code - Added comprehensive documentation
  • Updated the relevant documentation or specification - Added VERBOSE_TESTING.md
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed - Local verification completed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@aljo242
Copy link

aljo242 commented Jun 23, 2025

@DeVikingMark lint failing

@DeVikingMark
Copy link
Author

@aljo242 thanks for the review, I went through and cleaned up those issues.

Got rid of the security warnings by removing the reflect/runtime imports in the chainsuite. Was using them to get suite names but honestly it was overkill - now just parsing the test name directly which works fine and doesn't trigger any warnings.

The e2e_test.go file was a mess - same logging pattern duplicated in every single test. Refactored it into one helper function since they were all doing identical start/pass/fail logging anyway. Should be much easier to work with now.

Everything should build without the lint errors now. The verbose logging is still there, just implemented better.

@aljo242
Copy link

aljo242 commented Jun 24, 2025

looks like there is one more lint error. tagging @vladjdk to validate if this addresses the linked issue

@aljo242
Copy link

aljo242 commented Jun 30, 2025

@DeVikingMark still lint issues

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 15, 2025
@github-actions github-actions bot removed the stale label Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make testing more verbose
2 participants