CBG-4432: Implement Delete on the BlipTesterClient and enable delete-related topology tests #7251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrks
commented
Dec 19, 2024
torcolvin
reviewed
Dec 20, 2024
| @@ -314,6 +314,32 @@ func (btcc *BlipTesterCollectionClient) GetDoc(docID string) ([]byte, *DocVersio | |||
| return latestRev.body, &latestRev.version | |||
| } | |||
|
|
|||
| // IsTombstoned returns true if the latest version of the doc is a tombstone. | |||
There was a problem hiding this comment.
I am actually not sure if couchbase lite uses the terminology tombstone? I think this function is fine but I wonder if the name is confusing because we consider having server tombstones, and sync gateway tombstones as separate things and this is neither.
There was a problem hiding this comment.
I think tombstone is standard terminology across all of Couchbase for a soft or replicated delete. I'm not sure this is a misuse of the term.
| func (btcc *BlipTesterCollectionClient) IsTombstoned(docID string) (bool, error) { | ||
| doc, exists := btcc.getClientDoc(docID) | ||
| if !exists { | ||
| return false, base.ErrNotFound |
There was a problem hiding this comment.
is wrapping these errors with the docid going to be helpful if they fail?
There was a problem hiding this comment.
I don't think so. The caller knows the doc ID and can choose to log it/wrap it at that point
…ecause of poor Windows time resolution
torcolvin
approved these changes
Dec 20, 2024
adamcfraser
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-4432
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2873/GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2874/