Skip to content

CBG-4257 add HLV into BlipTesterCollectionClient #7264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

torcolvin
Copy link
Collaborator

@torcolvin torcolvin commented Jan 6, 2025

I created AddHLVRev in addition to AddRev since there would be a lot of places where code would need to change. I have a proposed refactor to drop the error arg out of AddRev and I could evaluate whether we would want to change the signature everywhere in rest package and not just topology tests.

My initial revision of this PR put HLV into DocVersion but Ben convinced me not to do this because DocVersion is used as a map key in blip tester, which breaks some semantics. Additionally, we use DocVersion to abstract CV/revtree id only, so adding HLV means that you could end up with two versions where the cv was the same, but one would have a PV. This version is also a lot simpler.

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

@torcolvin torcolvin changed the title CBG-4257 add HLV into DocVersion [WIP do not review] CBG-4257 add HLV into DocVersion Jan 6, 2025
@torcolvin torcolvin changed the title [WIP do not review] CBG-4257 add HLV into DocVersion CBG-4257 add HLV into BlipTesterCollectionClient Jan 6, 2025
@adamcfraser adamcfraser merged commit 3db570d into release/anemone Jan 6, 2025
36 checks passed
@adamcfraser adamcfraser deleted the CBG-4257 branch January 6, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants