CBG-4257 add HLV into BlipTesterCollectionClient #7264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created
AddHLVRev
in addition toAddRev
since there would be a lot of places where code would need to change. I have a proposed refactor to drop the error arg out ofAddRev
and I could evaluate whether we would want to change the signature everywhere inrest
package and not just topology tests.My initial revision of this PR put HLV into
DocVersion
but Ben convinced me not to do this becauseDocVersion
is used as a map key in blip tester, which breaks some semantics. Additionally, we useDocVersion
to abstract CV/revtree id only, so adding HLV means that you could end up with two versions where the cv was the same, but one would have a PV. This version is also a lot simpler.Pre-review checklist
fmt.Print
,log.Print
, ...)base.UD(docID)
,base.MD(dbName)
)docs/api
Integration Tests
GSI=true,xattrs=true
https://jenkins.sgwdev.com/job/SyncGateway-Integration/2876/