Revert "Test-only tech-debt cleanup: Make TestCtx use stdlib testing.Context() instead of a DIY version"
#7672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng.Conte…" This reverts commit 6396718.
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous change that made TestCtx use the standard library's testing.Context() instead of a custom implementation. The revert was necessary because the original change caused unintended side-effects in topology tests that relied on observing cancellation behavior within cleanup code.
- Reverts
TestCtxfunction to use a custom context implementation with manual cancellation - Restores the previous behavior where context cancellation is handled via
t.Cleanup(cancelCtx)
torcolvin
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7669
Had unintended side-effects on topology tests which used this context in a way that observed cancellation inside
Cleanup()code.Wasn't caught until merge because topology tests don't run in PRs.
Will revisit after 4.0