Skip to content

Support new jenkins #7680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
Merged

Support new jenkins #7680

merged 1 commit into from
Aug 12, 2025

Conversation

torcolvin
Copy link
Collaborator

Required change is to rename credentials to not have spaces, jenkins can not add a credential with spaces

Improvements:

  • don't run test compilation, since we are just going to run the build latest
  • remove disabled tests we can't run:
    • mac/windows tests (gosigar/rosmar sqlite3 use cgo)
    • litecore tests using a fixed docker remove
  • remove static checks that are run as part of golangci-lint (errcheck, govet, gofmt)
  • do not wipe go cache to make new builds on the same machine faster

Required change is to rename credentials to not have spaces, jenkins can
not add a credential with spaces

Improvements:

- don't run test compilation, since we are just going to run the build
  latest
- remove disabled tests we can't run:
  - mac/windows tests (gosigar/rosmar sqlite3 use cgo)
  - litecore tests using a fixed docker remove
- remove static checks that are run as part of golangci-lint (errcheck,
  govet, gofmt)
- do not wipe go cache to make new builds on the same machine faster
@Copilot Copilot AI review requested due to automatic review settings August 12, 2025 20:44
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Jenkins pipeline configuration to support a new Jenkins environment by addressing credential naming requirements and streamlining the build process. The changes remove build steps that cannot run due to dependency issues and eliminate redundant static checks.

Key changes:

  • Rename SSH credential to remove spaces (Jenkins requirement)
  • Remove disabled build stages for macOS/Windows and LiteCore tests
  • Eliminate redundant static checks already covered by golangci-lint

@torcolvin torcolvin enabled auto-merge (squash) August 12, 2025 21:14
@torcolvin torcolvin merged commit 8a7f39c into main Aug 12, 2025
24 of 25 checks passed
@torcolvin torcolvin deleted the jenkinsfile-improvements branch August 12, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants