fix race condition #7689
Open
fix race condition #7689
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a data race condition in the BLIP testing client where a shallow copy of the Hybrid Logical Vector (HLV) was being shared across goroutines. The race occurred when one goroutine was reading the HLV for logging purposes while another was modifying it, leading to concurrent map access violations.
- Updates the
_proposeChangesEntryForDocmethod to create a deep copy of the HLV instead of a shallow copy
| @@ -295,7 +295,7 @@ func (cd *clientDoc) _proposeChangesEntryForDoc() *proposeChangeBatchEntry { | |||
| } | |||
| revTreeIDHistory = append(revTreeIDHistory, cd._revisionsBySeq[seq].version.RevTreeID) | |||
| } | |||
| return &proposeChangeBatchEntry{docID: cd.id, version: latestRev.version, revTreeIDHistory: revTreeIDHistory, hlvHistory: latestRev.HLV, latestServerVersion: cd._latestServerVersion, seq: cd._latestSeq, isDelete: latestRev.isDelete} | |||
| return &proposeChangeBatchEntry{docID: cd.id, version: latestRev.version, revTreeIDHistory: revTreeIDHistory, hlvHistory: *latestRev.HLV.Copy(), latestServerVersion: cd._latestServerVersion, seq: cd._latestSeq, isDelete: latestRev.isDelete} | |||
There was a problem hiding this comment.
The dereferencing of latestRev.HLV.Copy() could lead to a panic if latestRev.HLV is nil. Consider adding a nil check or ensuring Copy() returns a non-nil pointer.
Suggested change
| return &proposeChangeBatchEntry{docID: cd.id, version: latestRev.version, revTreeIDHistory: revTreeIDHistory, hlvHistory: *latestRev.HLV.Copy(), latestServerVersion: cd._latestServerVersion, seq: cd._latestSeq, isDelete: latestRev.isDelete} | |
| var hlvCopy db.HybridLogicalVector | |
| if latestRev.HLV != nil { | |
| hlvCopy = *latestRev.HLV.Copy() | |
| } else { | |
| hlvCopy = *db.NewHybridLogicalVector() | |
| } | |
| return &proposeChangeBatchEntry{ | |
| docID: cd.id, | |
| version: latestRev.version, | |
| revTreeIDHistory: revTreeIDHistory, | |
| hlvHistory: hlvCopy, | |
| latestServerVersion: cd._latestServerVersion, | |
| seq: cd._latestSeq, | |
| isDelete: latestRev.isDelete, | |
| } |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
I don't think this is is necessary for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes data race since the HLV was a shallow copy: