Upgrade to ctapipe 0.24 #69
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-typo bugfix : in b equation (1-p**2) instead of (1-p)**2
-optimisation of multiprocessing (unshared variables)
SPE fit for run 3942 at 1400V
integration window length propagation
PhotoStat computation
Gain computation with SPE fit and Photo-statistic methods
Add dependency on `ctapipe_io_nectarcam`.
Install `ctapipe_io_nectarcam` through pypi.
Flake8 formatting on DQM
"BaselineSubtractedNeighborPeakWindowSum" extractor (bug unfixed) -bugfix when using extractor on waveforms 3D (ctapipe written for 2D)
Enable all ctapipe charge extractors
* tests for charges_component * test charge compopent + core component refactored * bugfix when ArgumentError are raised bugfix : nsamples waveformcontainer whas missing new getters * test for waveforms_component * base test for flatfiled SPE component * minor changes in photostat * test flatfield spe components * test photostat component * test for spe makers * add pyqtgraph dependencies * need to fix pyqt6 in trr suite * Test installing freeglut3-dev for pyqt in CI on Ubuntu runners * We seem to be hitting pytest-dev/pytest#3216. Try reducing the number of threads to 1 in CI * Test all imports on top * add xvfb to allow X11 display with pyqtgraph * Install Qt 5 dependencies on macOS in CI * Install system packages on runner before setting up python environment * using platform selectors in conda recipe * install xquartz on macOS in CI * fix pyqt again * reactive multi proc tests --------- Co-authored-by: guillaume.grolleron <ggroller@lpnhe.in2p3.fr> Co-authored-by: jlenain <jlenain@in2p3.fr>
* Use secrets to upload reports to Codecov.io
* Add a new flat field container * Add all necessary fields in FlatFieldContainer * Add new component for computation of flat field coefficient * Update flat field tools * New script for flat field tests * Add flatfieldContainer and preFlatFieldComponent import * implement of comments and cleaning * example script to run the flat field tool * Fix conflicts following merge of PR #163 * Renamed script to avoid any conflict with pytest * implement changes to use the same components for the 2 passes * example of how to run the flat field tool twice, including functions to calculate gain, hi/lo ratio and identify bad pixels * Resolve conflicts with `main` following merge of PR #168 --------- Co-authored-by: Jean-Philippe Lenain <jlenain@users.noreply.github.com>
* Add dependencies for Qt in Apptainer recipe * Add "yes" option for new mamba version
* Test fixing API doc on ReadTheDocs * Try fixing the doc by adding mock imports * Cleanup Sphinx config file
Fix workflow to publish on PyPI using a Trusted Publisher (see https://docs.pypi.org/trusted-publishers/using-a-publisher/)
* Try fixing deployment on PyPI, due to misformatted README.rst
* cleaner way to get the extractor string asociated to extractor kwargs provided -> not anymore sensitive to the order of kargs given by user -> It deals smoothly If user set kwargs to default value * The search of saved containers (SPE,Charge,wfs) is more robust -> Exception raised and cautch properly when file no found * propagation of changes in makers * script updates + fix of broken photostat code * update of shell scripts --------- Co-authored-by: guillaume.grolleron <ggroller@lpnhe.in2p3.fr>
* move TRR test suite into nectarchain * add h5py dependency * add lmfit to pyproject.toml * fix docstring * rebase on main * Fix Sphinx intermapping with PyQt documentation * Switch back to PyQt5 instead of PyQt6, to be able to launch the TRR GUI, on Linux at least * To try to ensure that the TRR GUI is launchable both from Linux and macOS * very simple unit test for TRR * change test_gui to work on macos * remove pyqt6 * install pyqt5 in CI for mac * sqlite issue * check pyqt installation in CI * install pyqt with brew before mamba installation on mac * add --no-deps to pip install nectarchain for pytest * add cleaner pip installation of nectarchain * clean separation of the installation through pip and mamba * tomlib -> toml for python < 3.11 * fix pip install * clean * Remove any use of PyQt6 in TRR GUI * Try to re-simplify the installation of dependencies for CI tests * Upload codecov report only for 1 platform/python version/installation method, not for all of them. --------- Co-authored-by: guillaume.grolleron <ggroller@lpnhe.in2p3.fr> Co-authored-by: jlenain <jlenain@in2p3.fr>
* DQM jobs on DIRAC via code deployed on CVMFS * Add an option with the possibility to launch DIRAC jobs in local mode, for debugging or for these long NectarCAM runs which fail on the grid due to large memory consumption
Co-authored-by: guillaume.grolleron <ggroller@lpnhe.in2p3.fr>
* thermal tests final scripts * Starting the photostat script and plot procedure * Adding Gain and Charge plots * renaming folder and removing duplicates
…irectories (#189) * Try to download files on DIRAC both from /vo.cta.in2p3.fr and from /ctao base directories * Raise exception if files not found on DIRAC
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
- Coverage 85.43% 85.37% -0.07%
==========================================
Files 7 7
Lines 934 937 +3
==========================================
+ Hits 798 800 +2
- Misses 136 137 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ed from (n_pix, n_sample) to (n_chan, n_pix, n_chan)
guillaumegrolleron
force-pushed
the
ctapipe-0.24-bis
branch
from
b10cfbb to
409a6c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.