Skip to content

Fix configure-git.sh #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025
Merged

Fix configure-git.sh #117

merged 1 commit into from
Aug 7, 2025

Conversation

MetRonnie
Copy link
Member

Description

Follow-up to #116

git config without the --global option fails when used before checkout 🤦

Checklist

  • I have read the contributing instructions in README.md and have opened this against the correct branch & milestone

@MetRonnie MetRonnie added this to the v1 milestone Aug 7, 2025
@MetRonnie MetRonnie self-assigned this Aug 7, 2025
@MetRonnie MetRonnie added bug Something isn't working small labels Aug 7, 2025
@MetRonnie MetRonnie marked this pull request as draft August 7, 2025 12:30
@MetRonnie MetRonnie marked this pull request as ready for review August 7, 2025 12:31
@@ -20,4 +20,4 @@ git config --global user.name "github-actions[bot]"
git config --global user.email "41898282+github-actions[bot]@users.noreply.github.com"
git config push.default current || true # won't work if cwd is not git repo

git config set advice.diverging false
git config --global advice.diverging false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the set argument?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and set doesn't seem to work with --global 🤷

Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, else whatever

@MetRonnie MetRonnie merged commit e04ce5c into cylc:v1 Aug 7, 2025
14 checks passed
@MetRonnie MetRonnie deleted the branch-sync-fix branch August 7, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants