Skip to content

ed25519-dalek: bring signature identifiers #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

baloo
Copy link
Contributor

@baloo baloo commented Jan 22, 2025

This allows to use ed25519 to create certificates for example.

Related to #707 & RustCrypto/signatures#889

Partially reverts #712

@rozbb
Copy link
Contributor

rozbb commented Jun 4, 2025

Also approved. Just wanna rerun the tests somehow

@baloo baloo force-pushed the baloo/ed25519-dalek/signature-identifier branch from 5164063 to 0e8fed9 Compare June 4, 2025 04:15
@baloo baloo marked this pull request as draft June 4, 2025 04:16
…c counterpart

This allows to use ed25519 to create certificates for example

This partially reverts dalek-cryptography#712
@baloo baloo force-pushed the baloo/ed25519-dalek/signature-identifier branch from 0e8fed9 to d0198a1 Compare June 4, 2025 04:26
@baloo baloo marked this pull request as ready for review June 4, 2025 04:26
@baloo
Copy link
Contributor Author

baloo commented Jun 4, 2025

Rebased to get the tests running, realized it was partially fixed by #712 although I don't believe we needed the DynSignatureAlgorithmIdentifier but SignatureAlgorithmIdentifier was enough.

@baloo
Copy link
Contributor Author

baloo commented Jun 4, 2025

for the rest of the tests, I think the fix is in #762

@tarcieri tarcieri force-pushed the rustcrypto-new-releases branch 5 times, most recently from 8af71de to 9b4ae94 Compare July 7, 2025 16:19
@tarcieri tarcieri deleted the branch dalek-cryptography:rustcrypto-new-releases July 7, 2025 17:34
@tarcieri tarcieri closed this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants