Don't implicitly enable zeroize for ed25519-dalek alloc feature #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! @tarcieri is this technically breaking? It could make existing code cease to zeroize structs |
|
https://doc.dalek.rs/merlin/index.html |
|
wait...did someone took over merlin crate? despite it is for crypto but it is not from dalek... |
|
@stevefan1999-personal yes, it moved to https://github.com/zkcrypto/merlin |
|
@rozbb it might technically be considered breaking, yes. Would be safer to do at a major version boundary |
|
Ok agreed. I labeled this so we can come back to it next major release |
tarcieri
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to compile
ed25519-dalekusing the new https://github.com/Rust-GPU/Rust-CUDA reboot and they mentioned they fixed a lot of issue, and I tried to include curve25519-dalek and it does miraculously compile, except it has to be withoutzeroizewhich is complaining about atomic fence not supported on PTX, and I have to use the equivalent intrinsic in cuda_std instead.As a quick demo for an internal finite field arithmetic + SIMD project and I rather need performance, I don't need zeroize at all. So a quick solution is to just disable it.
Anyway, I noticed with ed25519-dalek, when you enable the alloc feature, zeroize is implicitly enabled. This PR just add a single character to fix that