ed: Expose hazmat::raw_sign_byupdate()
for streamed signing
#765
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you want to sign a serialized object, you have to serialize it in full, then sign it. When memory is constrained, this is hard.
This PR defines a function,
hazmat::raw_sign_byupdate
, which, rather than taking a single contiguous message slice, takes aFn(&mut Digest)
that knows how to update a hasher with the parts of the message. So, in the case of serialization, the closure will simply serialize each component to a small buffer, doh.update(buf)
, then fill the buffer with the next serialized component, etc.This comes from discussion here, here, and hypothetical impl here.
This is feature-gated behind
hazmat
because it takes an expanded secret key, which is possible to catastrophically misuse.@mkj