-
-
Notifications
You must be signed in to change notification settings - Fork 36
Task/release #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/release #524
Conversation
Chore/better field alignment
Fix/config validation
Caution Review failedThe pull request is closed. WalkthroughAdds a config validation “off” mode (docs, schema, constants, logic), broadens and retypes schema fields, expands and reorganises public config and Immich API models, adjusts multiple exported struct field orders, introduces type-conversion before schema validation, and bumps embedded version metadata. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant App as Kiosk App
participant Loader as Config Loader
participant Typing as ConfigTypes
participant Schema as JSON Schema Validator
User->>App: Start
App->>Loader: Load(config.yaml / env)
Loader-->>App: Raw settings (map)
App->>Loader: Determine validation level
alt level == "off"
Note over App,Loader: Validation disabled
App-->>App: Use raw/parsed config
else level in {"warning","error"}
App->>Typing: Convert raw settings to typed map
Typing-->>App: Typed settings (map[string]any)
App->>Schema: Validate(typed settings)
Schema-->>App: Result (ok | violations)
alt violations and level == "error"
App-->>User: Log errors and fail start
else violations and level == "warning"
App-->>User: Log warnings and continue
else ok
App-->>App: Proceed
end
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related PRs
Suggested labels
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.2.2)Error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0) 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (14)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary by CodeRabbit