Skip to content

Conversation

damongolding
Copy link
Owner

@damongolding damongolding commented Aug 28, 2025

Summary by CodeRabbit

  • New Features
    • New configuration options: disable navigation/sleep, custom CSS toggle and class, user/blacklist lists, kiosk version.
  • Improvements
    • Config validation can be turned off.
    • Time format accepts “12/24” as string or number.
    • Arrays enforce unique items (e.g., people, albums, tags, iframe).
    • Weather coordinates accept numbers or strings.
    • Kiosk fetched assets size now constrained (1–1000).
  • Documentation
    • README updated to include “off” for config validation level.
  • Chores
    • Version bumped to 0.23.2-beta.1.

Copy link
Contributor

coderabbitai bot commented Aug 28, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds a config validation “off” mode (docs, schema, constants, logic), broadens and retypes schema fields, expands and reorganises public config and Immich API models, adjusts multiple exported struct field orders, introduces type-conversion before schema validation, and bumps embedded version metadata.

Changes

Cohort / File(s) Summary
Documentation
README.md
Documented config_validation_level allowing "off" in config tables.
Schema
config.schema.json
Added/updated root and nested properties (e.g., disable_navigation, custom_css, blacklist, user, kiosk.version). Allowed "off" for config_validation_level. Added uniqueItems to arrays. Broadened types (time formats accept "12"/"24" or 12/24; weather lat/lon accept number/string). Added constraints (fetched_assets_size 1–1000).
Config core
internal/config/config.go, internal/config/config_validation.go
Greatly expanded Config surface (many new public fields, nested groups, client data). Changed YAML validation flow: isValidYAML now returns error; Load updated. Added validation disable when level is "off". Introduced ConfigTypes and typed-map conversion before JSON Schema validation using Go loader.
Kiosk constants
internal/kiosk/kiosk.go
Added ConfigValidationOff constant ("off").
Common types
internal/common/common.go
Reordered several struct fields; embedded config.Config into ViewData.
Immich API models
internal/immich/immich.go, internal/immich/immich_server.go
Major model reshaping: added/reordered many exported fields (ExifInfo, Asset, Memory, UserResponse, search bodies/responses). Added new filters/flags to search. Included PersonResponseDto in APIResponse. Moved Licensed within ServerAboutResponse.
Demo
internal/demo/demo.go
Moved IsAdmin within LoginResponse; adjusted log messages text.
Utils
internal/utils/utils.go
Reordered fields in Color.
Video
internal/video/video.go
Moved mu within Manager.
Weather models
internal/weather/weather.go
Reordered/added exported fields across Location, Weather, Data, Sys; added Weather.Name, Weather.Sys.
Webhooks
internal/webhooks/webhooks.go
Moved Meta to top of Payload; repositioned AssetCount after Config.
Build/Versioning
taskfile.yml
Bumped VERSION to 0.23.2-beta.1.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant App as Kiosk App
  participant Loader as Config Loader
  participant Typing as ConfigTypes
  participant Schema as JSON Schema Validator

  User->>App: Start
  App->>Loader: Load(config.yaml / env)
  Loader-->>App: Raw settings (map)

  App->>Loader: Determine validation level
  alt level == "off"
    Note over App,Loader: Validation disabled
    App-->>App: Use raw/parsed config
  else level in {"warning","error"}
    App->>Typing: Convert raw settings to typed map
    Typing-->>App: Typed settings (map[string]any)
    App->>Schema: Validate(typed settings)
    Schema-->>App: Result (ok | violations)
    alt violations and level == "error"
      App-->>User: Log errors and fail start
    else violations and level == "warning"
      App-->>User: Log warnings and continue
    else ok
      App-->>App: Proceed
    end
  end
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Possibly related PRs

  • Chore/better field alignment #521 — Adds "off" config validation level and corresponding schema/docs; overlaps constants and validation flow.
  • Fix/config validation #520 — Modifies config validation to support additional levels; touches README, schema, and validation logic similarly.
  • Task/release #516 — Introduces validation level handling in kiosk constants/logic that this PR extends with "off".

Suggested labels

breaking-change

Poem

I thump my paw at YAML’s gate,
“Validation off?”—we calibrate.
New fields sprout like clover bright,
Schemas bloom in morning light.
Assets wink, the weather sings,
Webhooks hop with typed-up springs.
Version bumps—my whiskers ring!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.2.2)

Error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)
The command is terminated due to an error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9e88777 and 63644fe.

📒 Files selected for processing (14)
  • README.md (1 hunks)
  • config.schema.json (16 hunks)
  • internal/common/common.go (2 hunks)
  • internal/config/config.go (9 hunks)
  • internal/config/config_validation.go (3 hunks)
  • internal/demo/demo.go (3 hunks)
  • internal/immich/immich.go (8 hunks)
  • internal/immich/immich_server.go (1 hunks)
  • internal/kiosk/kiosk.go (1 hunks)
  • internal/utils/utils.go (1 hunks)
  • internal/video/video.go (1 hunks)
  • internal/weather/weather.go (3 hunks)
  • internal/webhooks/webhooks.go (1 hunks)
  • taskfile.yml (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch task/release

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@damongolding damongolding merged commit 4325f3e into main Aug 28, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant