Skip to content

Commit 008884f

Browse files
author
Marcos Alves
committed
feat: improve kernelexecutor error reject (#279)
1 parent 7e153dc commit 008884f

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

packages/react/src/jupyter/kernel/KernelExecutor.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -258,13 +258,9 @@ export class KernelExecutor {
258258
break;
259259
case 'error':
260260
{
261-
// NOTE: This block that was here previously cannot extract the properties consistently,
262-
//causing the Promise to never be rejected in case of an execution error.
263-
// const { ename, evalue, traceback } = (
264-
// content as any as KernelMessage.IErrorMsg
265-
// ).content;
261+
const { ename, evalue, traceback } = content as KernelMessage.IReplyErrorContent;
266262
this._executed.reject(
267-
`${content.ename}: ${content.evalue}\n${(content.traceback ?? []).join('\n')}`
263+
`${ename}: ${evalue}\n${(traceback ?? []).join('\n')}`
268264
);
269265
}
270266
break;

0 commit comments

Comments
 (0)