Skip to content

Add lint, format and type checks and basic tests. Update code style and fix CI. #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025

Conversation

goanpeca
Copy link
Collaborator

@goanpeca goanpeca commented Aug 14, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings August 14, 2025 20:54
@goanpeca goanpeca self-assigned this Aug 14, 2025
@goanpeca goanpeca marked this pull request as draft August 14, 2025 20:54
@goanpeca goanpeca changed the title Update storybook to use latest version, update stories and add basic … Update CI tests Aug 14, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Storybook infrastructure to use the latest version, modernizes MDX import paths, and adds comprehensive testing capabilities. The changes focus on migrating from Storybook 9.0.0-alpha to 9.1.2 stable while adding automated testing for both stories and documentation pages.

Key changes include:

  • Upgrade to Storybook 9.1.2 with simplified addon configuration
  • Update all MDX files to use the correct import path for Storybook blocks
  • Add test runner configuration and custom test scripts for MDX documentation validation
  • Create mock components to prevent kernel startup issues in test environments

Reviewed Changes

Copilot reviewed 45 out of 46 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
storybook/package.json Updates Storybook dependencies to v9.1.2 and adds test runner capabilities
storybook/.storybook/main.ts Simplifies addon configuration by replacing essentials with docs addon
storybook/src/stories/*.mdx Updates import paths from @storybook/blocks to @storybook/addon-docs/blocks
storybook/test-storybook.js Adds custom Playwright-based test for MDX documentation rendering
storybook/test-runner-jest.config.js Configures Jest test runner for Storybook tests
storybook/src/stories/RichEditorMock.tsx Creates mock component to avoid kernel startup in test environments

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@goanpeca goanpeca closed this Aug 14, 2025
@goanpeca goanpeca reopened this Aug 14, 2025
@goanpeca goanpeca force-pushed the enh/updates branch 14 times, most recently from 2ffb5aa to 806e366 Compare August 15, 2025 05:39
@goanpeca goanpeca requested a review from echarles August 15, 2025 05:39
@goanpeca goanpeca marked this pull request as ready for review August 15, 2025 05:39
@goanpeca goanpeca changed the title Update CI tests Add lint, format and type checks. Update code style and fix CI. Aug 15, 2025
@goanpeca goanpeca changed the title Add lint, format and type checks. Update code style and fix CI. Add lint, format and type checks and basic tests. Update code style and fix CI. Aug 15, 2025
@goanpeca goanpeca mentioned this pull request Aug 15, 2025
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thx @goanpeca

@echarles echarles merged commit dde14ec into datalayer:main Aug 15, 2025
4 checks passed
@goanpeca goanpeca deleted the enh/updates branch August 15, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants