Handle parameters on SGR-4 (underline) #477
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual underline styles aren't implemented, though they are stored.
davidrg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some recent terminal emulators have supported additional parameters on SGR-4 to set different underline styles as well as to turn off unline (eg,
\x1b[4:0m).While there are no immediate plans to support additional underline styles, these parameters should at least be handled, and the two that could easily be supported (no underline, and regular underline) ought to do the right thing in case some application decides to blindly use them.
This PR adds parsing for parameters on SGR-4, and if
KUI_EXTENDED_ULis defined those parameters will be stored and forwarded all the way to the KUI renderer where there is a TODO in place of an implementation.